correction

Author: Peyman-N

pipeline/src/base.py

@@ -37,16 +37,13 @@ def has_property(self, name):
 
     def __eq__(self, other: Node) -> bool:
 
-        eq = True
         for property in self.properties:
             property_other = getattr(other, property.name, None)
             property_self = getattr(self, property.name, None)
-            if property_other == property_self:
-                pass
-            else:
-                eq = False
+            if property_other != property_self:
+                return False
 
-        return eq
+        return True
 
     def to_jsonld(self, include_empty_properties=True, embed_linked_nodes=True, with_context=True):
         """

pipeline/src/collection.py

@@ -37,16 +37,15 @@ def __iter__(self):
 
     def __eq__(self, other):
 
-        eq = True
         # The current implementation assumes that nodes in both graphs are connected with the same link number.
-        for key in self.nodes.keys():
-            if key in other.nodes.keys():
-                if self.nodes[key] != other.nodes[key]:
-                    eq = False
+        for node_id in self.nodes:
+            if node_id in other.nodes.keys():
+                if self.nodes[node_id] != other.nodes[node_id]:
+                    return False
             else:
-                eq = False
+                return False
 
-        return eq
+        return True
 
     def add(self, *nodes):
         """

pipeline/tests/test_collections.py

@@ -65,7 +65,6 @@ def test_round_trip_multi_file():
     new_collection.load(test_output_dir)
 
     assert len(collection) == len(new_collection)
-    assert collection==new_collection
 
     for node in new_collection:
         if node.id == person.id: