Skip to content

Commit 6c88ed2

Browse files
committed
Convert _pv_display_flags to legal name
It is undefined behavior in C to have a file-level symbol begin with an underscore. This is a static function; there is no need for it to have a leading or trailing underscore to mark it as internal
1 parent b70be8d commit 6c88ed2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

dump.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ S_append_flags(pTHX_ SV *sv, U32 flags, const struct flag_to_name *start,
9595
| ((utf8) ? PERL_PV_ESCAPE_UNI : 0) )
9696

9797
#define _pv_display_for_dump(dsv, pv, cur, len, pvlim) \
98-
_pv_display_flags(aTHX_ dsv, pv, cur, len, pvlim, PERL_PV_ESCAPE_DWIM_ALL_HEX)
98+
pv_display_flags(aTHX_ dsv, pv, cur, len, pvlim, PERL_PV_ESCAPE_DWIM_ALL_HEX)
9999

100100
/*
101101
=for apidoc pv_escape
@@ -417,7 +417,7 @@ Perl_pv_pretty( pTHX_ SV *dsv, char const * const str, const STRLEN count,
417417
}
418418

419419
STATIC char *
420-
_pv_display_flags(pTHX_ SV *dsv, const char *pv, STRLEN cur, STRLEN len, STRLEN pvlim, I32 pretty_flags)
420+
pv_display_flags(pTHX_ SV *dsv, const char *pv, STRLEN cur, STRLEN len, STRLEN pvlim, I32 pretty_flags)
421421
{
422422
PERL_ARGS_ASSERT_PV_DISPLAY;
423423

@@ -445,7 +445,7 @@ Note that the final string may be up to 7 chars longer than pvlim.
445445
char *
446446
Perl_pv_display(pTHX_ SV *dsv, const char *pv, STRLEN cur, STRLEN len, STRLEN pvlim)
447447
{
448-
return _pv_display_flags(aTHX_ dsv, pv, cur, len, pvlim, 0);
448+
return pv_display_flags(aTHX_ dsv, pv, cur, len, pvlim, 0);
449449
}
450450

451451
/*

0 commit comments

Comments
 (0)