Skip to content

Commit 46d7cd4

Browse files
authored
Merge pull request #56 from PennChopMicrobiomeProgram/55-allow-explicit-sqlalchemy-uri-via-env
Define db URI directly in env
2 parents ccce42f + 23d3c61 commit 46d7cd4

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

app/metadatalib/src/metadatalib/__init__.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,13 @@
66
from sqlalchemy.orm import sessionmaker
77

88

9-
__version__ = "0.2.0"
9+
__version__ = "0.2.1"
1010

1111
try:
12-
db_host = os.environ["METADATA_DB_HOST"]
13-
db_user = os.environ["METADATA_DB_USER"]
14-
db_name = os.environ["METADATA_DB_NAME"]
15-
db_pswd = os.environ["METADATA_DB_PSWD"]
16-
SQLALCHEMY_DATABASE_URI = f"postgresql://{db_user}:{db_pswd}@{db_host}/{db_name}"
12+
SQLALCHEMY_DATABASE_URI = os.environ["METADATA_DB_URI"]
1713
except KeyError:
1814
sys.stderr.write(
19-
"Missing database connection information in environment, using test SQLite database.\n"
20-
)
21-
sys.stderr.write(
22-
f"METADATA_DB_HOST: {os.environ.get('METADATA_DB_HOST')}\nMETADATA_DB_USER: {os.environ.get('METADATA_DB_USER')}\nMETADATA_DB_NAME: {os.environ.get('METADATA_DB_NAME')}\nMETADATA_DB_PSWD: {os.environ.get('METADATA_DB_PSWD')}\n"
15+
"Missing METADATA_DB_URI in environment, using test SQLite database.\n"
2316
)
2417
SQLALCHEMY_DATABASE_URI = f"sqlite:///{Path(__file__).parent.parent.parent.parent.parent.resolve()}/metadata.sqlite3"
2518

@@ -29,5 +22,6 @@
2922
session = Session()
3023
except SQLAlchemyError as e:
3124
# Need to do handling here
25+
sys.stderr.write(f"Error connecting to database: {SQLALCHEMY_DATABASE_URI}\n")
3226
raise e
3327
session = None

0 commit comments

Comments
 (0)