Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links on the website #3402

Open
harshagr70 opened this issue Dec 28, 2024 · 5 comments
Open

Fix broken links on the website #3402

harshagr70 opened this issue Dec 28, 2024 · 5 comments

Comments

@harshagr70
Copy link
Contributor

A detailed mention about this issue - PecanProject/PecanProject.github.io#69
proposed solution - Need to render the source rmd files to get the required changes and targeting the links to open in the new tab

@harshagr70
Copy link
Contributor Author

Hi @dlebauer ,
I've implemented the changes as per your suggestions. When you have a moment, I’d appreciate it if you could review them. Thank you again for your guidance and support!

harshagr70 added a commit to harshagr70/pecan that referenced this issue Jan 22, 2025
harshagr70 added a commit to harshagr70/pecan that referenced this issue Jan 23, 2025
harshagr70 added a commit to harshagr70/pecan that referenced this issue Jan 25, 2025
@harshagr70
Copy link
Contributor Author

harshagr70 commented Jan 27, 2025

Thankyou !! @robkooper for reviewing and merging the PR , not closing the issue as the changes are yet to be reflected as the code is expected to be build by the automation script for the changes to work , what are your views !!?

@robkooper
Copy link
Member

there is a problem with the build scripts, it will try and use the repo for the person that merged (me in this case) to write the docker images.

@harshagr70
Copy link
Contributor Author

@robkooper Thanks for the clarification! I see now that the issue lies with the automation script trying to build Docker images using the repository of the person who merged the PR. As suggested, it seems like we need to adjust the build script to reference the correct repository context.

Would it be helpful to open a new issue to specifically track this build script problem? I’ll leave this issue open until that’s addressed, as the changes won’t work until the automation script is fixed.

@robkooper
Copy link
Member

done see #3426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants