minor symfony#39544 Remove :void in test function signatures (fabpot)

This PR was merged into the 4.4 branch.

Discussion
----------

Remove :void in test function signatures

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a<!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

I've added a new rule in fabbot to detect usage of `: void` in test method signatures to please @nicolas-grekas :)

Commits
-------

47fcf4a Remove :void in test function signatures

Author: fabpot

src/Symfony/Bundle/SecurityBundle/Tests/Functional/EventAliasTest.php

@@ -24,7 +24,7 @@
 
 final class EventAliasTest extends AbstractWebTestCase
 {
-    public function testAliasedEvents(): void
+    public function testAliasedEvents()
     {
         $client = $this->createClient(['test_case' => 'AliasedEvents', 'root_config' => 'config.yml']);
         $container = $client->getContainer();

src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/Compiler/ExceptionListenerPassTest.php

@@ -31,7 +31,7 @@ public function testExitsWhenTwigIsNotAvailable()
         $this->assertTrue($builder->hasDefinition('twig.exception_listener'));
     }
 
-    public function testRemovesTwigExceptionListenerWhenNoExceptionListenerControllerExists(): void
+    public function testRemovesTwigExceptionListenerWhenNoExceptionListenerControllerExists()
     {
         $builder = new ContainerBuilder();
         $builder->register('twig', Environment::class);
@@ -45,7 +45,7 @@ public function testRemovesTwigExceptionListenerWhenNoExceptionListenerControlle
         $this->assertFalse($builder->hasDefinition('twig.exception_listener'));
     }
 
-    public function testRemovesTwigExceptionListenerIfTwigIsNotUsedAsTemplateEngine(): void
+    public function testRemovesTwigExceptionListenerIfTwigIsNotUsedAsTemplateEngine()
     {
         $builder = new ContainerBuilder();
         $builder->register('twig', Environment::class);
@@ -60,7 +60,7 @@ public function testRemovesTwigExceptionListenerIfTwigIsNotUsedAsTemplateEngine(
         $this->assertFalse($builder->hasDefinition('twig.exception_listener'));
     }
 
-    public function testRemovesKernelExceptionListenerIfTwigIsUsedAsTemplateEngine(): void
+    public function testRemovesKernelExceptionListenerIfTwigIsUsedAsTemplateEngine()
     {
         $builder = new ContainerBuilder();
         $builder->register('twig', Environment::class);

src/Symfony/Component/BrowserKit/Tests/Test/Constraint/BrowserCookieValueSameTest.php

@@ -21,7 +21,7 @@
 
 class BrowserCookieValueSameTest extends TestCase
 {
-    public function testConstraint(): void
+    public function testConstraint()
     {
         $browser = $this->getBrowser();
         $constraint = new BrowserCookieValueSame('foo', 'bar', false, '/path');

src/Symfony/Component/BrowserKit/Tests/Test/Constraint/BrowserHasCookieTest.php

@@ -21,7 +21,7 @@
 
 class BrowserHasCookieTest extends TestCase
 {
-    public function testConstraint(): void
+    public function testConstraint()
     {
         $browser = $this->getBrowser();
         $constraint = new BrowserHasCookie('foo', '/path');
@@ -42,7 +42,7 @@ public function testConstraint(): void
         $this->fail();
     }
 
-    public function testConstraintWithWrongPath(): void
+    public function testConstraintWithWrongPath()
     {
         $browser = $this->getBrowser();
         $constraint = new BrowserHasCookie('foo', '/other');
@@ -57,7 +57,7 @@ public function testConstraintWithWrongPath(): void
         $this->fail();
     }
 
-    public function testConstraintWithWrongDomain(): void
+    public function testConstraintWithWrongDomain()
     {
         $browser = $this->getBrowser();
         $constraint = new BrowserHasCookie('foo', '/path', 'example.org');

src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php

@@ -872,7 +872,7 @@ public function provideFormat(): array
         ];
     }
 
-    public function testIterate(): void
+    public function testIterate()
     {
         $bar = new ProgressBar($output = $this->getOutputStream(), 0, 0);
 
@@ -887,7 +887,7 @@ public function testIterate(): void
         );
     }
 
-    public function testIterateUncountable(): void
+    public function testIterateUncountable()
     {
         $bar = new ProgressBar($output = $this->getOutputStream(), 0, 0);
 
@@ -936,7 +936,7 @@ public function testBarWidthWithMultilineFormat()
         putenv('COLUMNS=120');
     }
 
-    public function testMinAndMaxSecondsBetweenRedraws(): void
+    public function testMinAndMaxSecondsBetweenRedraws()
     {
         $bar = new ProgressBar($output = $this->getOutputStream());
         $bar->setRedrawFrequency(1);
@@ -959,7 +959,7 @@ public function testMinAndMaxSecondsBetweenRedraws(): void
         );
     }
 
-    public function testMaxSecondsBetweenRedraws(): void
+    public function testMaxSecondsBetweenRedraws()
     {
         $bar = new ProgressBar($output = $this->getOutputStream(), 0, 0);
         $bar->setRedrawFrequency(4); // disable step based redraws
@@ -1014,7 +1014,7 @@ public function testMinSecondsBetweenRedraws()
         );
     }
 
-    public function testNoWriteWhenMessageIsSame(): void
+    public function testNoWriteWhenMessageIsSame()
     {
         $bar = new ProgressBar($output = $this->getOutputStream(), 2);
         $bar->start();

src/Symfony/Component/Console/Tests/Helper/TableTest.php

@@ -1263,7 +1263,7 @@ protected function getOutputContent(StreamOutput $output)
         return str_replace(\PHP_EOL, "\n", stream_get_contents($output->getStream()));
     }
 
-    public function testWithColspanAndMaxWith(): void
+    public function testWithColspanAndMaxWith()
     {
         $table = new Table($output = $this->getOutputStream());
 

src/Symfony/Component/DependencyInjection/Tests/Compiler/ValidateEnvPlaceholdersPassTest.php

@@ -206,7 +206,7 @@ public function testEnvIsNotUnset()
         $this->assertSame($expected, $container->resolveEnvPlaceholders($ext->getConfig()));
     }
 
-    public function testEmptyEnvWhichCannotBeEmptyForScalarNode(): void
+    public function testEmptyEnvWhichCannotBeEmptyForScalarNode()
     {
         $container = new ContainerBuilder();
         $container->registerExtension($ext = new EnvExtension());
@@ -225,7 +225,7 @@ public function testEmptyEnvWhichCannotBeEmptyForScalarNode(): void
      * @group legacy
      * @expectedDeprecation Setting path "env_extension.scalar_node_not_empty_validated" to an environment variable is deprecated since Symfony 4.3. Remove "cannotBeEmpty()", "validate()" or include a prefix/suffix value instead.
      */
-    public function testEmptyEnvWhichCannotBeEmptyForScalarNodeWithValidation(): void
+    public function testEmptyEnvWhichCannotBeEmptyForScalarNodeWithValidation()
     {
         $container = new ContainerBuilder();
         $container->registerExtension($ext = new EnvExtension());
@@ -238,7 +238,7 @@ public function testEmptyEnvWhichCannotBeEmptyForScalarNodeWithValidation(): voi
         $this->assertSame($expected, $container->resolveEnvPlaceholders($ext->getConfig()));
     }
 
-    public function testPartialEnvWhichCannotBeEmptyForScalarNode(): void
+    public function testPartialEnvWhichCannotBeEmptyForScalarNode()
     {
         $container = new ContainerBuilder();
         $container->registerExtension($ext = new EnvExtension());
@@ -251,7 +251,7 @@ public function testPartialEnvWhichCannotBeEmptyForScalarNode(): void
         $this->assertSame($expected, $container->resolveEnvPlaceholders($ext->getConfig()));
     }
 
-    public function testEnvWithVariableNode(): void
+    public function testEnvWithVariableNode()
     {
         $container = new ContainerBuilder();
         $container->registerExtension($ext = new EnvExtension());
@@ -268,7 +268,7 @@ public function testEnvWithVariableNode(): void
      * @group legacy
      * @expectedDeprecation A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.
      */
-    public function testConfigurationWithoutRootNode(): void
+    public function testConfigurationWithoutRootNode()
     {
         $container = new ContainerBuilder();
         $container->registerExtension(new EnvExtension(new EnvConfigurationWithoutRootNode()));
@@ -288,7 +288,7 @@ public function testEmptyConfigFromMoreThanOneSource()
         $this->addToAssertionCount(1);
     }
 
-    public function testDiscardedEnvInConfig(): void
+    public function testDiscardedEnvInConfig()
     {
         $container = new ContainerBuilder();
         $container->setParameter('env(BOOLISH)', '1');

src/Symfony/Component/DomCrawler/Tests/Test/Constraint/CrawlerSelectorAttributeValueSameTest.php

@@ -19,7 +19,7 @@
 
 class CrawlerSelectorAttributeValueSameTest extends TestCase
 {
-    public function testConstraint(): void
+    public function testConstraint()
     {
         $constraint = new CrawlerSelectorAttributeValueSame('input[name="username"]', 'value', 'Fabien');
         $this->assertTrue($constraint->evaluate(new Crawler('<html><body><form><input type="text" name="username" value="Fabien">'), '', true));

src/Symfony/Component/DomCrawler/Tests/Test/Constraint/CrawlerSelectorExistsTest.php

@@ -19,7 +19,7 @@
 
 class CrawlerSelectorExistsTest extends TestCase
 {
-    public function testConstraint(): void
+    public function testConstraint()
     {
         $constraint = new CrawlerSelectorExists('title');
         $this->assertTrue($constraint->evaluate(new Crawler('<html><head><title>'), '', true));

src/Symfony/Component/DomCrawler/Tests/Test/Constraint/CrawlerSelectorTextContainsTest.php

@@ -19,7 +19,7 @@
 
 class CrawlerSelectorTextContainsTest extends TestCase
 {
-    public function testConstraint(): void
+    public function testConstraint()
     {
         $constraint = new CrawlerSelectorTextContains('title', 'Foo');
         $this->assertTrue($constraint->evaluate(new Crawler('<html><head><title>Foobar'), '', true));

src/Symfony/Component/DomCrawler/Tests/Test/Constraint/CrawlerSelectorTextSameTest.php

@@ -19,7 +19,7 @@
 
 class CrawlerSelectorTextSameTest extends TestCase
 {
-    public function testConstraint(): void
+    public function testConstraint()
     {
         $constraint = new CrawlerSelectorTextSame('title', 'Foo');
         $this->assertTrue($constraint->evaluate(new Crawler('<html><head><title>Foo'), '', true));

src/Symfony/Component/EventDispatcher/Tests/DependencyInjection/RegisterListenersPassTest.php

@@ -61,7 +61,7 @@ public function testValidEventSubscriber()
         $this->assertEquals($expectedCalls, $eventDispatcherDefinition->getMethodCalls());
     }
 
-    public function testAliasedEventSubscriber(): void
+    public function testAliasedEventSubscriber()
     {
         $builder = new ContainerBuilder();
         $builder->setParameter('event_dispatcher.event_aliases', [AliasedEvent::class => 'aliased_event']);
@@ -210,7 +210,7 @@ public function testInvokableEventListener()
         $this->assertEquals($expectedCalls, $definition->getMethodCalls());
     }
 
-    public function testAliasedEventListener(): void
+    public function testAliasedEventListener()
     {
         $container = new ContainerBuilder();
         $eventAliases = [AliasedEvent::class => 'aliased_event'];
@@ -251,7 +251,7 @@ public function testAliasedEventListener(): void
         $this->assertEquals($expectedCalls, $definition->getMethodCalls());
     }
 
-    public function testOmitEventNameOnTypedListener(): void
+    public function testOmitEventNameOnTypedListener()
     {
         $container = new ContainerBuilder();
         $container->setParameter('event_dispatcher.event_aliases', [AliasedEvent::class => 'aliased_event']);
@@ -284,7 +284,7 @@ public function testOmitEventNameOnTypedListener(): void
         $this->assertEquals($expectedCalls, $definition->getMethodCalls());
     }
 
-    public function testOmitEventNameOnUntypedListener(): void
+    public function testOmitEventNameOnUntypedListener()
     {
         $container = new ContainerBuilder();
         $container->register('foo', InvokableListenerService::class)->addTag('kernel.event_listener', ['method' => 'onEvent']);
@@ -297,7 +297,7 @@ public function testOmitEventNameOnUntypedListener(): void
         $registerListenersPass->process($container);
     }
 
-    public function testOmitEventNameAndMethodOnUntypedListener(): void
+    public function testOmitEventNameAndMethodOnUntypedListener()
     {
         $container = new ContainerBuilder();
         $container->register('foo', InvokableListenerService::class)->addTag('kernel.event_listener');
@@ -313,7 +313,7 @@ public function testOmitEventNameAndMethodOnUntypedListener(): void
     /**
      * @requires PHP 7.2
      */
-    public function testOmitEventNameAndMethodOnGenericListener(): void
+    public function testOmitEventNameAndMethodOnGenericListener()
     {
         $container = new ContainerBuilder();
         $container->register('foo', GenericListener::class)->addTag('kernel.event_listener');
@@ -326,7 +326,7 @@ public function testOmitEventNameAndMethodOnGenericListener(): void
         $registerListenersPass->process($container);
     }
 
-    public function testOmitEventNameOnSubscriber(): void
+    public function testOmitEventNameOnSubscriber()
     {
         $container = new ContainerBuilder();
         $container->register('subscriber', IncompleteSubscriber::class)

src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/StringToFloatTransformerTest.php

@@ -37,14 +37,14 @@ public function testTransform($from, $to): void
         $this->assertSame($to, $transformer->transform($from));
     }
 
-    public function testFailIfTransformingANonString(): void
+    public function testFailIfTransformingANonString()
     {
         $this->expectException('Symfony\Component\Form\Exception\TransformationFailedException');
         $transformer = new StringToFloatTransformer();
         $transformer->transform(1.0);
     }
 
-    public function testFailIfTransformingANonNumericString(): void
+    public function testFailIfTransformingANonNumericString()
     {
         $this->expectException('Symfony\Component\Form\Exception\TransformationFailedException');
         $transformer = new StringToFloatTransformer();
@@ -77,7 +77,7 @@ public function testReverseTransform($from, $to, int $scale = null): void
         $this->assertSame($to, $transformer->reverseTransform($from));
     }
 
-    public function testFailIfReverseTransformingANonNumeric(): void
+    public function testFailIfReverseTransformingANonNumeric()
     {
         $this->expectException('Symfony\Component\Form\Exception\TransformationFailedException');
         $transformer = new StringToFloatTransformer();

src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php

@@ -729,7 +729,7 @@ public function provideEmptyData()
         ];
     }
 
-    public function testSubmitStringWithCustomInputFormat(): void
+    public function testSubmitStringWithCustomInputFormat()
     {
         $form = $this->factory->create(static::TESTED_TYPE, null, [
             'model_timezone' => 'UTC',

src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php

@@ -1048,7 +1048,7 @@ public function provideEmptyData()
         ];
     }
 
-    public function testSubmitStringWithCustomInputFormat(): void
+    public function testSubmitStringWithCustomInputFormat()
     {
         $form = $this->factory->create(static::TESTED_TYPE, null, [
             'model_timezone' => 'UTC',