Merge pull request #67 from tronsha/feature/remove-attribute-if-condition-false

Add attribute with if condition

Author: tronsha

src/Compiler.php

@@ -105,6 +105,13 @@ class Compiler
      */
     protected $includeAttributes = ['class', 'style'];
 
+    /**
+     * @var string[]
+     */
+    protected $ifAttributes = ['checked', 'selected', 'disabled'];
+
+
+
     /**
      * Compiler constructor.
      */
@@ -192,6 +199,7 @@ public function convert(): string
         $html = $this->addVariableBlocks($html);
         $html = $this->replacePlaceholders($html);
         $html = $this->replaceScopedPlaceholders($html);
+        $html = $this->replaceAttributeWithIfConditionPlaceholders($html);
 
         $html = preg_replace('/<template>\s*(.*)\s*<\/template>/ism', '$1', $html);
         $html = preg_replace('/<\/?template[^>]*?>/i', '', $html);
@@ -513,8 +521,15 @@ private function handleAttributeBinding(DOMElement $node): void
                 continue;
             }
 
+            // makes no sense to use this in code, but it must handled.
+            if ($value === 'false') {
+                continue;
+            }
+
             $dynamicValues = $this->handleBinding($value, $name, $node);
 
+            $addIfAroundAttribute = in_array($name, $this->ifAttributes);
+
             /* @see https://gitlab.gnome.org/GNOME/libxml2/-/blob/LIBXML2.6.32/HTMLtree.c#L657 */
             switch ($name) {
                 case 'href':
@@ -535,7 +550,14 @@ private function handleAttributeBinding(DOMElement $node): void
                     break;
             }
 
-            $node->setAttribute($name, $this->implodeAttributeValue($name, $dynamicValues, $staticValues));
+            $value = $this->implodeAttributeValue($name, $dynamicValues, $staticValues);
+
+            if ($addIfAroundAttribute && $value) {
+                $value = $name . '|' . base64_encode($value);
+                $name = '__ATTRIBUTE_WITH_IF_CONDITION__';
+            }
+
+            $node->setAttribute($name, $value);
         }
     }
 
@@ -1263,4 +1285,31 @@ private function replaceScopedPlaceholders(string $html): string
 
         return $html;
     }
+
+    /**
+     * @throws ReflectionException
+     */
+    private function replaceAttributeWithIfConditionPlaceholders(string $html): string
+    {
+        $pattern = '/__ATTRIBUTE_WITH_IF_CONDITION__="([-a-zA-Z0-9]+)\|([a-zA-Z0-9+=]+)"/';
+        if (preg_match_all($pattern, $html, $matches, PREG_SET_ORDER)) {
+            foreach ($matches as $match) {
+                $name = $match[1];
+                $value = base64_decode($match[2]);
+                $condition = trim(str_replace(['__DOUBLE_CURLY_OPEN__', '__DOUBLE_CURLY_CLOSE__'], '', $value));
+                $value = $this->replacePlaceholders($value);
+                $condition = $this->replacePlaceholders($condition);
+                if (in_array($name, ['checked', 'selected', 'disabled'])) {
+                    $value = $name;
+                }
+                $html = str_replace(
+                    $match[0],
+                    '{% if ' . $condition . ' %}' . $name . '="' . $value . '"{% endif %}',
+                    $html
+                );
+            }
+        }
+
+        return $html;
+    }
 }

tests/AttributeIfTrueTest.php

@@ -0,0 +1,39 @@
+<?php
+
+namespace Paneon\VueToTwig\Tests;
+
+use Exception;
+
+class IfAttributesTest extends AbstractTestCase
+{
+    /**
+     * @dataProvider dataProvider
+     *
+     * @throws Exception
+     */
+    public function testAttributeIfTrue($template, $expected)
+    {
+        $compiler = $this->createCompiler($template);
+
+        $actual = $compiler->convert();
+
+        $this->assertEqualHtml($expected, $actual);
+    }
+
+    /**
+     * @return array
+     */
+    public function dataProvider()
+    {
+        return [
+            [
+                '<template><form><input type="checkbox" :checked="false"></form></template>',
+                '<form class="{{ class|default(\'\') }}" style="{{ style|default(\'\') }}"><input type="checkbox"></form>',
+            ],
+            [
+                '<template><form><input type="checkbox" :checked="foo"></form></template>',
+                '<form class="{{ class|default(\'\') }}" style="{{ style|default(\'\') }}"><input type="checkbox" {% if foo %}checked="checked"{% endif %}></form>',
+            ],
+        ];
+    }
+}

tests/VuePreTest.php

@@ -8,7 +8,6 @@ class VuePreTest extends AbstractTestCase
 {
     /**
      * @dataProvider dataProvider
-
      *
      * @throws Exception
      */