Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 4 Notebook Import Utils #5

Closed
brenterprises opened this issue Apr 4, 2020 · 4 comments
Closed

Chapter 4 Notebook Import Utils #5

brenterprises opened this issue Apr 4, 2020 · 4 comments

Comments

@brenterprises
Copy link

In the third code block in the Chapter 4 notebook

from utils import save_midi, save_plot

should be

from note_sequence_utils import save_midi, save_plot

@dubreuia
Copy link
Collaborator

dubreuia commented Apr 5, 2020

Fixed, thanks @brenterprises, let me know if you find anything else.

@Hasterios
Copy link

does not work for me on MacOSX Catalina, magenta 2.0.1, protobuf 3.12.2, tensorflow 2.2.0

@dubreuia
Copy link
Collaborator

dubreuia commented Jun 29, 2020

Hello @Hasterios, which branch are you using? The book was written using Magenta 1.1.7, but I've recently ported the code on Magenta 2.0.1 on https://github.com/PacktPublishing/hands-on-music-generation-with-magenta/tree/magenta-v2.0.1.

You can also check out the README at https://github.com/PacktPublishing/hands-on-music-generation-with-magenta/tree/magenta-v2.0.1#magenta-versioning and an article I've written on migrating to Magenta 2.0.1 for more information: https://alexandredubreuil.com/publications/2020-06-06-music-generation-with-magenta-2-0-1-a-migration-guide-from-version-1-1-7/

EDIT: this probably doesn't have anything to do with version, see #7 (comment)

@Hasterios
Copy link

Hello Dubreuia,
Thanks you for your quickness.
I'm using Magenta 2.0.1 of course. It was installed properly following your instructions. As you see, I'm working with the notebook, and it seems that the code is exactly the same in both branches (by the way).
No idea ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants