[analyzer] Print type for SymbolRegionValues when dumping to stream

ddcc · ddcc · commit bd6b03c8adba · 2016-12-05T20:30:11.000Z
Reviewers: NoQ, dcoughlin, zaks.anna Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D27365 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@288696 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/StaticAnalyzer/Core/SymbolManager.cpp b/lib/StaticAnalyzer/Core/SymbolManager.cpp
@@ -85,7 +85,8 @@ void SymbolMetadata::dumpToStream(raw_ostream &os) const {
 void SymbolData::anchor() { }
 
 void SymbolRegionValue::dumpToStream(raw_ostream &os) const {
-  os << "reg_$" << getSymbolID() << "<" << R << ">";
+  os << "reg_$" << getSymbolID()
+     << '<' << getType().getAsString() << ' ' << R << '>';
 }
 
 bool SymExpr::symbol_iterator::operator==(const symbol_iterator &X) const {
diff --git a/test/Analysis/expr-inspection.c b/test/Analysis/expr-inspection.c
@@ -7,7 +7,7 @@ void clang_analyzer_printState();
 void clang_analyzer_numTimesReached();
 
 void foo(int x) {
-  clang_analyzer_dump(x); // expected-warning{{reg_$0<x>}}
+  clang_analyzer_dump(x); // expected-warning{{reg_$0<int x>}}
   int y = 1;
   clang_analyzer_printState();
   for (; y < 3; ++y)

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,8 @@ void SymbolMetadata::dumpToStream(raw_ostream &os) const {`
`85`	`85`	`void SymbolData::anchor() { }`
`86`	`86`
`87`	`87`	`void SymbolRegionValue::dumpToStream(raw_ostream &os) const {`
`88`		`- os << "reg_$" << getSymbolID() << "<" << R << ">";`
	`88`	`+ os << "reg_$" << getSymbolID()`
	`89`	`+ << '<' << getType().getAsString() << ' ' << R << '>';`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`bool SymExpr::symbol_iterator::operator==(const symbol_iterator &X) const {`