Skip to content

Commit 5e564d3

Browse files
author
Stefan Maksimovic
committed
Revert r304953 for release 5.0.0
This is causing failures when compiling clang with -O3 as one of the structures used by clang is passed by value and uses the fastcc calling convention. Faliures manifest for stage2 mips build. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@310057 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent c4f2a80 commit 5e564d3

File tree

6 files changed

+1
-110
lines changed

6 files changed

+1
-110
lines changed

include/clang/Driver/Options.td

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2019,10 +2019,6 @@ def mdspr2 : Flag<["-"], "mdspr2">, Group<m_Group>;
20192019
def mno_dspr2 : Flag<["-"], "mno-dspr2">, Group<m_Group>;
20202020
def msingle_float : Flag<["-"], "msingle-float">, Group<m_Group>;
20212021
def mdouble_float : Flag<["-"], "mdouble-float">, Group<m_Group>;
2022-
def mmadd4 : Flag<["-"], "mmadd4">, Group<m_Group>,
2023-
HelpText<"Enable the generation of 4-operand madd.s, madd.d and related instructions.">;
2024-
def mno_madd4 : Flag<["-"], "mno-madd4">, Group<m_Group>,
2025-
HelpText<"Disable the generation of 4-operand madd.s, madd.d and related instructions.">;
20262022
def mmsa : Flag<["-"], "mmsa">, Group<m_Group>,
20272023
HelpText<"Enable MSA ASE (MIPS only)">;
20282024
def mno_msa : Flag<["-"], "mno-msa">, Group<m_Group>,

lib/Basic/Targets/Mips.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,6 @@ void MipsTargetInfo::getTargetDefines(const LangOptions &Opts,
166166
if (HasMSA)
167167
Builder.defineMacro("__mips_msa", Twine(1));
168168

169-
if (DisableMadd4)
170-
Builder.defineMacro("__mips_no_madd4", Twine(1));
171-
172169
Builder.defineMacro("_MIPS_SZPTR", Twine(getPointerWidth(0)));
173170
Builder.defineMacro("_MIPS_SZINT", Twine(getIntWidth()));
174171
Builder.defineMacro("_MIPS_SZLONG", Twine(getLongWidth()));

lib/Basic/Targets/Mips.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ class LLVM_LIBRARY_VISIBILITY MipsTargetInfo : public TargetInfo {
5252
enum MipsFloatABI { HardFloat, SoftFloat } FloatABI;
5353
enum DspRevEnum { NoDSP, DSP1, DSP2 } DspRev;
5454
bool HasMSA;
55-
bool DisableMadd4;
5655

5756
protected:
5857
bool HasFP64;
@@ -63,7 +62,7 @@ class LLVM_LIBRARY_VISIBILITY MipsTargetInfo : public TargetInfo {
6362
: TargetInfo(Triple), IsMips16(false), IsMicromips(false),
6463
IsNan2008(false), IsSingleFloat(false), IsNoABICalls(false),
6564
CanUseBSDABICalls(false), FloatABI(HardFloat), DspRev(NoDSP),
66-
HasMSA(false), DisableMadd4(false), HasFP64(false) {
65+
HasMSA(false), HasFP64(false) {
6766
TheCXXABI.set(TargetCXXABI::GenericMIPS);
6867

6968
setABI((getTriple().getArch() == llvm::Triple::mips ||
@@ -320,8 +319,6 @@ class LLVM_LIBRARY_VISIBILITY MipsTargetInfo : public TargetInfo {
320319
DspRev = std::max(DspRev, DSP2);
321320
else if (Feature == "+msa")
322321
HasMSA = true;
323-
else if (Feature == "+nomadd4")
324-
DisableMadd4 = true;
325322
else if (Feature == "+fp64")
326323
HasFP64 = true;
327324
else if (Feature == "-fp64")

lib/Driver/ToolChains/Arch/Mips.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,6 @@ void mips::getMIPSTargetFeatures(const Driver &D, const llvm::Triple &Triple,
297297

298298
AddTargetFeature(Args, Features, options::OPT_mno_odd_spreg,
299299
options::OPT_modd_spreg, "nooddspreg");
300-
AddTargetFeature(Args, Features, options::OPT_mno_madd4, options::OPT_mmadd4,
301-
"nomadd4");
302300
AddTargetFeature(Args, Features, options::OPT_mlong_calls,
303301
options::OPT_mno_long_calls, "long-calls");
304302
AddTargetFeature(Args, Features, options::OPT_mmt, options::OPT_mno_mt, "mt");

test/CodeGen/mips-madd4.c

Lines changed: 0 additions & 87 deletions
This file was deleted.

test/Preprocessor/init.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4840,16 +4840,6 @@
48404840
// RUN: | FileCheck -match-full-lines -check-prefix MIPS-MSA %s
48414841
// MIPS-MSA:#define __mips_msa 1
48424842
//
4843-
// RUN: %clang_cc1 -target-feature +nomadd4 \
4844-
// RUN: -E -dM -triple=mips-none-none < /dev/null \
4845-
// RUN: | FileCheck -match-full-lines -check-prefix MIPS-NOMADD4 %s
4846-
// MIPS-NOMADD4:#define __mips_no_madd4 1
4847-
//
4848-
// RUN: %clang_cc1 \
4849-
// RUN: -E -dM -triple=mips-none-none < /dev/null \
4850-
// RUN: | FileCheck -match-full-lines -check-prefix MIPS-MADD4 %s
4851-
// MIPS-MADD4-NOT:#define __mips_no_madd4 1
4852-
//
48534843
// RUN: %clang_cc1 -target-cpu mips32r3 -target-feature +nan2008 \
48544844
// RUN: -E -dM -triple=mips-none-none < /dev/null \
48554845
// RUN: | FileCheck -match-full-lines -check-prefix MIPS-NAN2008 %s

0 commit comments

Comments
 (0)