Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid data in podcast import #1179

Open
3 tasks
cavis opened this issue Jan 22, 2025 · 0 comments
Open
3 tasks

Handle invalid data in podcast import #1179

cavis opened this issue Jan 22, 2025 · 0 comments
Labels
Level: Intermediate Smooth for some, bumpy for others Priority: Normal Cruising speed Size: S Less than a day

Comments

@cavis
Copy link
Member

cavis commented Jan 22, 2025

Right now, it appears invalid podcast import data just completely errors the Shoryuken job (which then keeps getting retried, setting off queue-oldest-message alarms). For instance:

Error performing PodcastImportJob

Validation failed: Podcast link Not a valid URL

We should:

  • Rescue the error in the podcast import job, and set the status to error (not entirely clear why this isn't already happening)
  • Rescue validation errors, record them in some field on the PodcastImport record, set their attributes to nil, and save
  • Maybe also do that on episode imports
@cavis cavis added Level: Intermediate Smooth for some, bumpy for others Size: S Less than a day Priority: Normal Cruising speed labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: Intermediate Smooth for some, bumpy for others Priority: Normal Cruising speed Size: S Less than a day
Projects
None yet
Development

No branches or pull requests

1 participant