Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion fail on OpenMP runtime #51

Closed
simoatze opened this issue Nov 10, 2017 · 6 comments
Closed

Assertion fail on OpenMP runtime #51

simoatze opened this issue Nov 10, 2017 · 6 comments

Comments

@simoatze
Copy link
Member

Two tests (task-two and parallel-reduction-nowait) are failing because of:

OMP: Error #13: Assertion failure at kmp_sched.cpp(85).

@simoatze
Copy link
Member Author

@jprotze do you have any idea why?

@jprotze
Copy link
Contributor

jprotze commented Nov 10, 2017

Yes, to provide a conforming implementation, we had to introduce compiler support. With old compilers, the flag is not set with a valid value, which results in the assert.
There is a deprecated-workshare branch, that changes this assert to a warning about an outdated compiler.

@dongahn
Copy link
Contributor

dongahn commented Nov 10, 2017

Can we cherry-pick that?

@jprotze
Copy link
Contributor

jprotze commented Nov 10, 2017

I'm currently pushing this patch to upstream (I guess it will land in the next few days):
https://reviews.llvm.org/D39890

Until then, you can simply use the branch for testing: https://github.com/OpenMPToolsInterface/LLVM-openmp/tree/deprecated-workshare

@simoatze : With that fix in upstream LLVM, you can switch to the upstream LLVM/OpenMP runtime.

@simoatze
Copy link
Member Author

@jprotze Thanks! I tried the deprecated-workshare and it passes all the tests.
I'll switch to the upstream LLVM/OpenMP and do more tests.

@jprotze
Copy link
Contributor

jprotze commented Nov 10, 2017

The patch landed in upstream llvm/OpenMP about an hour ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants