Fixes based on PHPStan output (ref #2201)

Author: gsherwood

src/Files/DummyFile.php

@@ -54,7 +54,7 @@ public function __construct($content, Ruleset $ruleset, Config $config)
             $path = $config->stdinPath;
         }
 
-        return parent::__construct($path, $ruleset, $config);
+        parent::__construct($path, $ruleset, $config);
 
     }//end __construct()
 

src/Files/File.php

@@ -1120,18 +1120,6 @@ public function getWarningCount()
     }//end getWarningCount()
 
 
-    /**
-     * Returns the number of successes recorded.
-     *
-     * @return int
-     */
-    public function getSuccessCount()
-    {
-        return $this->successCount;
-
-    }//end getSuccessCount()
-
-
     /**
      * Returns the number of fixable errors/warnings raised.
      *

src/Files/LocalFile.php

@@ -59,7 +59,7 @@ public function __construct($path, Ruleset $ruleset, Config $config)
 
         $this->reloadContent();
 
-        return parent::__construct($this->path, $ruleset, $config);
+        parent::__construct($this->path, $ruleset, $config);
 
     }//end __construct()
 
@@ -88,7 +88,8 @@ public function process()
         }
 
         if ($this->configCache['cache'] === false) {
-            return parent::process();
+            parent::process();
+            return;
         }
 
         $hash  = md5_file($this->path);

src/Ruleset.php

@@ -67,7 +67,7 @@ class Ruleset
      * The key is the fully qualified name of the sniff class
      * and the value is the sniff object.
      *
-     * @var array<string, \PHP_CodeSniffer\Sniff>
+     * @var array<string, \PHP_CodeSniffer\Sniffs\Sniff>
      */
     public $sniffs = [];
 
@@ -87,7 +87,7 @@ class Ruleset
      * The key is the token name being listened for and the value
      * is the sniff object.
      *
-     * @var array<int, \PHP_CodeSniffer\Sniff>
+     * @var array<int, \PHP_CodeSniffer\Sniffs\Sniff>
      */
     public $tokenListeners = [];
 

src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php

@@ -1372,7 +1372,7 @@ public function process(File $phpcsFile, $stackPtr)
      * @param int                         $change    The difference in length between
      *                                               the old and new indent.
      *
-     * @return void
+     * @return bool
      */
     protected function adjustIndent(File $phpcsFile, $stackPtr, $length, $change)
     {

src/Standards/PEAR/Sniffs/Functions/FunctionCallSignatureSniff.php

@@ -176,7 +176,7 @@ public function process(File $phpcsFile, $stackPtr)
      * @param array                       $tokens      The stack of tokens that make up
      *                                                 the file.
      *
-     * @return void
+     * @return bool
      */
     public function isMultiLineCall(File $phpcsFile, $stackPtr, $openBracket, $tokens)
     {

src/Standards/PEAR/Sniffs/Functions/FunctionDeclarationSniff.php

@@ -214,7 +214,7 @@ public function process(File $phpcsFile, $stackPtr)
      * @param array                       $tokens      The stack of tokens that make up
      *                                                 the file.
      *
-     * @return void
+     * @return bool
      */
     public function isMultiLineDeclaration($phpcsFile, $stackPtr, $openBracket, $tokens)
     {

src/Standards/PSR2/Sniffs/Classes/PropertyDeclarationSniff.php

@@ -65,7 +65,7 @@ protected function processMemberVar(File $phpcsFile, $stackPtr)
             if (empty($propertyInfo) === true) {
                 return;
             }
-        } catch (Exception $e) {
+        } catch (\Exception $e) {
             // Turns out not to be a property after all.
             return;
         }

src/Standards/PSR2/Sniffs/Namespaces/UseDeclarationSniff.php

@@ -274,7 +274,7 @@ public function process(File $phpcsFile, $stackPtr)
      * @param int                         $stackPtr  The position of the current token in
      *                                               the stack passed in $tokens.
      *
-     * @return void
+     * @return bool
      */
     private function shouldIgnoreUse($phpcsFile, $stackPtr)
     {

src/Tokenizers/CSS.php

@@ -35,7 +35,7 @@ public function __construct($content, Config $config, $eolChar='\n')
             throw new TokenizerException('File appears to be minified and cannot be processed');
         }
 
-        return parent::__construct($content, $config, $eolChar);
+        parent::__construct($content, $config, $eolChar);
 
     }//end __construct()