-
Notifications
You must be signed in to change notification settings - Fork 11
Added geographic_area feature type in Divisions theme for supporting cultural and functional regions. #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Noting that this will replace #360 |
jonahadkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
|
This looks great, thanks @pradeepbkkumar. Approved the PR, with one comment about the Right now, we've got these types in the theme:
The new IMO this naming convention would be fine.. but bringing this up because there was some initial concern with using |
Let's sync tomorrow on call on this. |
danabauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no proposed documentation plan to help users understand the nature of this change and how to use the new property and its data.
B. Related MINOR change steps
geographic_areain Divisions themeC. Public documentation and messaging plan
TODO.
Description
A geographic_area represents a functional or cultural region that may span across multiple administrative divisions. These areas capture regions defined by shared characteristics, community usage, cultural identity, or common perception rather than formal administrative boundaries.
The existing
divisionanddivision_areatypes are intentionally designed for formal administrative regions and work well for those use cases.To support informal, culturally recognized, or functionally defined regions, we introduce a new
geographic_areafeature type, withfunctionalandculturalsub-types. This separation maintains clarity for users while allowing the system to represent non-administrative, colloquial, or contextual regions accurately.Reference
Testing
./test.sh -m examples "divisions/geographic_area/.*"./test.sh -m counterexamples "divisions/geographic_area/.*"uv run pytest packagesChecklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation website
Update the hyperlink below to put the pull request number in.
[Docs preview for this PR.](https://dfhx9f55j8eg5.cloudfront.net/pr/<PUT THE PR # HERE>)