Skip to content

Conversation

@ecormany
Copy link
Contributor

@ecormany ecormany commented Nov 21, 2025

Overview

Link to opentrons.com in the header of docs.opentrons.com pages.

Addresses RTC-815.

image

Test Plan and Hands on Testing

Sandbox

Changelog

  • Add new partial override with extra
  • and hardcoded (our icon library version is black only).

Review requests

Is this the best way to do this?
Do we need the link to remain visible in the smallest responsive designs, when the tab bar collapses to a sidebar?

Risk assessment

low

Copy link
Contributor

@jwwojak jwwojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While unobtrusive, and essential, the banner is starting to fill up. And, OT-2 docs are coming, so possibly one more thing to add. Other than that, LGTM.

@ecormany
Copy link
Contributor Author

ecormany commented Dec 3, 2025

Yes, we'll definitely have to make sure that the top banner stays top-level in the future.

Copy link
Collaborator

@emilyburghardt emilyburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea and think the picture you shared in the PR looks great.

But, I'm not seeing it on my end in the sandbox? Resizing, reloading, etc. doesn't change it. Almost like I've got mobile version by default. Can clear the cache and try again.

Image

@ecormany
Copy link
Contributor Author

ecormany commented Dec 3, 2025

Almost like I've got mobile version by default.

Weird, is your zoom level set to 100%? I can get it to disappear when I hit the tablet-size breakpoint, but that's only if I make the window smaller or zoom in.

@emilyburghardt
Copy link
Collaborator

Aha, zooming in/out fixed it. somehow I was at 150% but didn't see it it any of my other tabs?? Anyways, this looks good.

@ecormany ecormany merged commit 3d95c1e into edge Dec 4, 2025
15 checks passed
@ecormany ecormany deleted the mkdocs-link-to-dotcom branch December 4, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants