Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image smaller than recommended size while it's not #16

Open
rmens opened this issue Mar 17, 2024 · 6 comments
Open

Image smaller than recommended size while it's not #16

rmens opened this issue Mar 17, 2024 · 6 comments

Comments

@rmens
Copy link

rmens commented Mar 17, 2024

I have this weird issue where ODR-PadEnc always logs that the file is smaller than recommended size, but it's not.

ODR-PadEnc encoding Slideshow from '/var/dab/slides/zwfm' and DLS from '/var/dab/zwfm.txt' to 'zwmf_pad'
ODR-PadEnc using charset UTF-8 (15)
ODR-PadEnc converting DLS texts to Complete EBU Latin
ODR-PadEnc Reinitialise PAD length to 6
ODR-PadEnc Warning: Image '/var/dab/slides/zwfm/2.jpg' smaller than recommended size (240 x 240 < 320 x 240 px)

This is with Debian 12 on ARM64. Here are the properties of the file.

root@dab2:/var/dab/slides/zwfm# identify -verbose 2.jpg 
Image:
  Filename: 2.jpg
  Format: JPEG (Joint Photographic Experts Group JFIF format)
  Mime type: image/jpeg
  Class: DirectClass
  Geometry: 423x423+0+0
  Resolution: 72x72
  Print size: 5.875x5.875
  Units: PixelsPerInch
  Colorspace: sRGB
  Type: TrueColor
  Base type: Undefined
  Endianness: Undefined
  Depth: 8-bit
  Properties:
    date:create: 2024-03-17T17:46:45+00:00
    date:modify: 2024-03-17T17:46:45+00:00
    exif:ColorSpace: 1
    exif:ComponentsConfiguration: 1, 2, 3, 0
    exif:ExifOffset: 102
    exif:ExifVersion: 48, 50, 50, 49
    exif:FlashPixVersion: 48, 49, 48, 48
    exif:PixelXDimension: 423
    exif:PixelYDimension: 423
    exif:SceneCaptureType: 0
    exif:YCbCrPositioning: 1
    jpeg:colorspace: 2
    jpeg:sampling-factor: 1x1,1x1,1x1
    signature: cc8e228c4c4ec4533b8ad976936cb70a9cc18c51afbc223ac96b1756c5dcbe0e
  Artifacts:
    filename: 2.jpg
    verbose: true
  Tainted: False
  Filesize: 112650B
  Number pixels: 178929
  Pixels per second: 44.6554MB
  User time: 0.000u
  Elapsed time: 0:01.004
  Version: ImageMagick 6.9.11-60 Q16 aarch64 2021-01-25 https://imagemagick.org
@basicmaster
Copy link
Member

Hmm, this looks strange...
Could you uploaded the affected sample image somewhere?

@rmens
Copy link
Author

rmens commented Mar 17, 2024

Here you go

2.zip

basicmaster added a commit that referenced this issue Mar 18, 2024
Mention whether the image was resized or not.

Fixes #16.
@basicmaster
Copy link
Member

In this case the warning actually applies to the resized image (the image is automatically resized from 423x423 to 240x240, keeping the aspect ratio). As the new resolution (still) doesn't meet the default resolution of 320x240, the warning is shown.

I added a fix to next to make clear that the resized image is meant here.

@rmens
Copy link
Author

rmens commented Mar 18, 2024

Ah thanks! So this is about a not optimal aspect ratio. How about a warning that the image should be in 4x3 aspect ratio for optimal results.

@basicmaster
Copy link
Member

This won't harm; I just extended the current warning text by an aspect ratio note.

@rmens
Copy link
Author

rmens commented Apr 4, 2024

After conducting tests with multiple images, it appears that everything is looking good on the next branch now. Might I suggest a 3.1 release, @basicmaster? It would be timely to do so, considering @colisee needs to rebuild some packages anyway to address #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants