From a8e67c7d0642f6b7e12ffc98af8495e66664d895 Mon Sep 17 00:00:00 2001 From: Lev Stipakov Date: Thu, 20 Feb 2025 08:43:27 +0100 Subject: [PATCH] dco-win: simplify control packets prepend code Eliminate unneeded temporary struct sockaddr_in buffer. Change-Id: Ie57f7b11157ab5ca8ff01e1c4f03a308117ff937 Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20250220074327.24922-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30942.html Signed-off-by: Gert Doering --- src/openvpn/socket.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/openvpn/socket.h b/src/openvpn/socket.h index c370f2c635d..2c33319d2b6 100644 --- a/src/openvpn/socket.h +++ b/src/openvpn/socket.h @@ -1125,15 +1125,11 @@ link_socket_write_win32(struct link_socket *sock, { if (to->dest.addr.sa.sa_family == AF_INET) { - struct sockaddr_in sa; - memcpy(&sa, &to->dest.addr.in4, sizeof(sa)); - buf_write_prepend(buf, &sa, sizeof(sa)); + buf_write_prepend(buf, &to->dest.addr.in4, sizeof(struct sockaddr_in)); } else { - struct sockaddr_in6 sa; - memcpy(&sa, &to->dest.addr.in6, sizeof(sa)); - buf_write_prepend(buf, &sa, sizeof(sa)); + buf_write_prepend(buf, &to->dest.addr.in6, sizeof(struct sockaddr_in6)); } }