Skip to content

Commit 93b0d00

Browse files
authored
Merge pull request #738 from OpenSignLabs/signPdf
fix: some webhook event are not working for second signer & add certificate in completed webhook
2 parents 24bf08c + d731951 commit 93b0d00

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

apps/OpenSignServer/cloud/parsefunction/callWebhook.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,11 @@ export default async function callWebhook(request) {
4848
}
4949
}
5050
}
51+
const docQuery = new Parse.Query('contracts_Document');
52+
const resDoc = await docQuery.get(docId, { useMasterKey: true });
5153
const extendcls = new Parse.Query('contracts_Users');
52-
extendcls.equalTo('UserId', { __type: 'Pointer', className: '_User', objectId: userId });
54+
extendcls.equalTo('objectId', resDoc.get('ExtUserPtr')?.id);
55+
// extendcls.equalTo('UserId', { __type: 'Pointer', className: '_User', objectId: userId });
5356
const res = await extendcls.first({ useMasterKey: true });
5457
if (res) {
5558
const extUser = JSON.parse(JSON.stringify(res));

apps/OpenSignServer/cloud/parsefunction/pdf/PDF.min.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,22 +123,23 @@ async function sendCompletedMail(e) {
123123
},
124124
});
125125
}
126-
async function sendDoctoWebhook(a, e, t, r) {
127-
let i = [];
128-
(i = r
126+
async function sendDoctoWebhook(a, e, t, r, i) {
127+
let s = [];
128+
(s = r
129129
? { name: r?.Name, email: r?.Email, phone: r?.Phone }
130130
: a?.Signers?.map(e => ({ name: e.Name, email: e.Email, phone: e.Phone })) || [
131131
{ name: a?.ExtUserPtr?.Name, email: a?.ExtUserPtr?.Email, phone: a?.ExtUserPtr?.Phone },
132132
]),
133133
a.ExtUserPtr?.Webhook &&
134134
((r =
135135
'signed' === t
136-
? { signer: i, signedAt: new Date() }
137-
: { signers: i, completedAt: new Date() }),
136+
? { signer: s, signedAt: new Date() }
137+
: { signers: s, completedAt: new Date() }),
138138
(t = {
139139
event: t,
140140
objectId: a?.objectId,
141141
file: e || '',
142+
...(i ? { certificate: i } : {}),
142143
name: a?.Name,
143144
note: a?.Note || '',
144145
description: a?.Description || '',
@@ -205,7 +206,7 @@ const sendMailsaveCertifcate = async (e, t, a, r, i, s) => {
205206
? console.log("don't send mail")
206207
: sendCompletedMail({ url: a, isCustomMail: r, doc: e, mailProvider: i }),
207208
saveFileUsage(o.length, t.imageUrl, s),
208-
sendDoctoWebhook(e, a, 'completed');
209+
sendDoctoWebhook(e, a, 'completed', '', t.imageUrl);
209210
};
210211
async function PDF(o) {
211212
try {

0 commit comments

Comments
 (0)