Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add city table to API #4

Open
colindavey opened this issue Dec 15, 2020 · 6 comments
Open

Add city table to API #4

colindavey opened this issue Dec 15, 2020 · 6 comments
Assignees

Comments

@colindavey
Copy link
Contributor

Make a CitiesController.cs in LittleHelpBook.Server, and follow the pattern from another controller to read the data and return JSON.

@colindavey colindavey self-assigned this Dec 15, 2020
@markdav-is
Copy link
Member

I think this was addressed in a PR!

@markdav-is
Copy link
Member

@colindavey we still need to deploy this right?

@colindavey
Copy link
Contributor Author

Yes, but first I need to get one more table and field implemented.

@markdav-is
Copy link
Member

markdav-is commented Dec 22, 2020

you can deploy with every PR and test it to make sure it's working. no reason to wait. feature branches and issues should be atomic. The workflow is open-issue->feature branch->PR->merge->deploy->test->close-issue. We also have dev-, test- and prod- mvp-studio environments. So we can also managing merging dev to main ala "gitflow"

@colindavey
Copy link
Contributor Author

I just did a draft PR to get feedback from you that I'm barking up the right tree. I'm still testing it and finding issues running locally. I'm shooting for a PR when I can successfully use the Swagger API locally. It's a process of updating the front end and the API in sync.

@markdav-is
Copy link
Member

we can try deploying to dev so you can test it online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants