Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0 #462

Open
10 of 11 tasks
zain-sohail opened this issue Jul 2, 2024 · 6 comments
Open
10 of 11 tasks

Version 1.0 #462

zain-sohail opened this issue Jul 2, 2024 · 6 comments

Comments

@zain-sohail
Copy link
Member

zain-sohail commented Jul 2, 2024

All changes are added to #437 before we finally merge to main

Breaking changes

Not breaking but should be done

Nice to haves

@rettigl
Copy link
Member

rettigl commented Feb 6, 2025

@zain-sohail Some of the tutorial notebooks right now show some of the figures cut off, because the column width of the docs page is limited. This mostly affects the Flash tutorials. Could you fix this, i.e. limit the figure sizes? For possible sizes, look at the mpes examples.

@zain-sohail
Copy link
Member Author

@zain-sohail Some of the tutorial notebooks right now show some of the figures cut off, because the column width of the docs page is limited. This mostly affects the Flash tutorials. Could you fix this, i.e. limit the figure sizes? For possible sizes, look at the mpes examples.

Could you show me an example? The figures in v1 docs all look shrunk to me, and seem to fit.

@rettigl
Copy link
Member

rettigl commented Feb 25, 2025

Could you show me an example? The figures in v1 docs all look shrunk to me, and seem to fit.
This is how it looks like for me (Firefox):

Image

@zain-sohail
Copy link
Member Author

That's interesting:

Image

I checked on another laptop:

Image

Perhaps it has to do with resolution. I can set it to another aspect ratio but I am not sure which is universal.

@zain-sohail
Copy link
Member Author

I checked with another monitor and indeed the issue you speak of arises. It seems that this is resolution dependent and I doubt we can achieve an ideal scenario for all monitors.

@rettigl
Copy link
Member

rettigl commented Feb 26, 2025

I checked with another monitor and indeed the issue you speak of arises. It seems that this is resolution dependent and I doubt we can achieve an ideal scenario for all monitors.

It only affects figures that are too wide. If we reduce the width for all figures to 6 or so, it does fit. See the mpes notebooks, where I did this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants