[frontend] Add openbas_nuclei to external contract types with findings

Author: RomuDeuxfois

openbas-front/src/admin/components/atomic_testings/atomic_testing/AtomicTestingRoutes.tsx

@@ -4,6 +4,7 @@ import { Route, Routes } from 'react-router';
 import { errorWrapper } from '../../../../components/Error';
 import NotFound from '../../../../components/NotFound';
 import type { InjectResultOverviewOutput } from '../../../../utils/api-types';
+import { externalContractTypesWithFindings } from '../../../../utils/injector_contract/InjectorContractUtils';
 
 interface Props { injectResultOverview: InjectResultOverviewOutput }
 
@@ -12,14 +13,12 @@ const AtomicTestingDetail = lazy(() => import('./AtomicTestingDetail'));
 const AtomicTestingFindings = lazy(() => import('./AtomicTestingFindings'));
 const AtomicTestingPayloadInfo = lazy(() => import('./payload_info/AtomicTestingPayloadInfo'));
 
-const openbasNmap = 'openbas_nmap';
-
 const AtomicTestingRoutes = ({ injectResultOverview }: Props) => {
   return (
     <Routes>
       <Route path="" element={errorWrapper(AtomicTesting)()} />
       {(injectResultOverview.inject_injector_contract?.injector_contract_payload
-        || injectResultOverview.inject_type === openbasNmap) && (
+        || externalContractTypesWithFindings.includes(injectResultOverview.inject_type ?? '')) && (
         <Route path="findings" element={errorWrapper(AtomicTestingFindings)()} />
       )}
       <Route path="detail" element={errorWrapper(AtomicTestingDetail)()} />

openbas-front/src/admin/components/atomic_testings/atomic_testing/AtomicTestingTabs.tsx

@@ -4,6 +4,7 @@ import { makeStyles } from 'tss-react/mui';
 
 import { useFormatter } from '../../../../components/i18n';
 import type { InjectResultOverviewOutput } from '../../../../utils/api-types';
+import { externalContractTypesWithFindings } from '../../../../utils/injector_contract/InjectorContractUtils';
 
 const useStyles = makeStyles()(theme => ({
   item: {
@@ -16,8 +17,6 @@ const useStyles = makeStyles()(theme => ({
 
 interface Props { injectResultOverview: InjectResultOverviewOutput }
 
-const openbasNmap = 'openbas_nmap';
-
 const AtomicTestingTabs = ({ injectResultOverview }: Props) => {
   const { classes } = useStyles();
   const { t } = useFormatter();
@@ -38,7 +37,7 @@ const AtomicTestingTabs = ({ injectResultOverview }: Props) => {
         className={classes.item}
       />
       {(injectResultOverview.inject_injector_contract?.injector_contract_payload
-        || injectResultOverview.inject_type === openbasNmap) && (
+        || externalContractTypesWithFindings.includes(injectResultOverview.inject_type ?? '')) && (
         <Tab
           component={Link}
           to={`/admin/atomic_testings/${injectResultOverview.inject_id}/findings`}

openbas-front/src/admin/components/simulations/simulation/injects/InjectIndexTabs.tsx

@@ -5,6 +5,7 @@ import { makeStyles } from 'tss-react/mui';
 import { BACK_LABEL, BACK_URI } from '../../../../../components/Breadcrumbs';
 import { useFormatter } from '../../../../../components/i18n';
 import type { Exercise as ExerciseType, InjectResultOverviewOutput } from '../../../../../utils/api-types';
+import { externalContractTypesWithFindings } from '../../../../../utils/injector_contract/InjectorContractUtils';
 
 const useStyles = makeStyles()(theme => ({
   item: {
@@ -22,8 +23,6 @@ interface Props {
   backuri?: string | null;
 }
 
-const openbasNmap = 'openbas_nmap';
-
 const InjectIndexTabs = ({ injectResultOverview, exercise, backlabel, backuri }: Props) => {
   const { classes } = useStyles();
   const { t } = useFormatter();
@@ -48,7 +47,7 @@ const InjectIndexTabs = ({ injectResultOverview, exercise, backlabel, backuri }:
         className={classes.item}
       />
       {(injectResultOverview.inject_injector_contract?.injector_contract_payload
-        || injectResultOverview.inject_type === openbasNmap) && (
+        || externalContractTypesWithFindings.includes(injectResultOverview.inject_type ?? '')) && (
         <Tab
           component={Link}
           to={computePath(`/admin/simulations/${exercise.exercise_id}/injects/${injectResultOverview.inject_id}/findings`)}

openbas-front/src/utils/injector_contract/InjectorContractUtils.ts

@@ -2,6 +2,8 @@ import * as R from 'ramda';
 
 import { type AttackPattern, type InjectorContractOutput } from '../api-types';
 
+export const externalContractTypesWithFindings = ['openbas_nmap', 'openbas_nuclei'];
+
 const computeAttackPatterns = (attackPatternIds: InjectorContractOutput['injector_contract_attack_patterns'], attackPatternsMap: Record<string, AttackPattern>) => {
   const attackPatternParents = (attackPatternIds ?? []).flatMap((attackPattern) => {
     const attackPatternParentId = attackPatternsMap[attackPattern]?.attack_pattern_parent;