Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoteproc/rpmsg: Wrong argument to safe_strcpy() #625

Closed
jonny-svaerd-arm opened this issue Oct 21, 2024 · 4 comments · Fixed by #626
Closed

remoteproc/rpmsg: Wrong argument to safe_strcpy() #625

jonny-svaerd-arm opened this issue Oct 21, 2024 · 4 comments · Fixed by #626
Assignees

Comments

@jonny-svaerd-arm
Copy link

In commit c3132d0 and 27bec14 the strncpy function is replaced by a new safe_strcpy function, however the last argument to some of the calls are made with sizeof(name) where name is a const char * (resulting in pointer size).

I'm guessing these most likely were intended to be strlen(name)?

Thanks!

@arnopo
Copy link
Collaborator

arnopo commented Oct 21, 2024

Good catch! what i cannot understand is why the CI does not detect it...
i will investigate and send a fix

@arnopo arnopo linked a pull request Oct 21, 2024 that will close this issue
@arnopo
Copy link
Collaborator

arnopo commented Oct 21, 2024

@jonny-svaerd-arm: Please, could you have a look to the #626 fix?

@arnopo arnopo self-assigned this Oct 21, 2024
@jonny-svaerd-arm
Copy link
Author

Looks good to me @arnopo. Thanks for fixing it so quickly, much appreciated.

@arnopo
Copy link
Collaborator

arnopo commented Oct 21, 2024

Looks good to me @arnopo. Thanks for fixing it so quickly, much appreciated.

Thank you for reporting the issue! t was good timing as we are starting tests for the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants