Skip to content

Commit 2b50319

Browse files
committed
WIP
1 parent 1dd06e3 commit 2b50319

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

openeo_driver/datacube.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,18 +633,21 @@ def apply_dimension(
633633
context: Optional[dict] = None,
634634
env: EvalEnv,
635635
) -> "DriverVectorCube":
636+
# Is callback a single run_udf node process?
636637
single_run_udf = SingleRunUDFProcessGraph.parse_or_none(process)
637638

638639
if single_run_udf:
639640
# Process with single "run_udf" node
640641
# TODO: check provided dimension with actual dimension of the cube
642+
# TODO: also support along geometries dim (e.g. when it's the only dim)?
641643
if dimension in (self.DIM_BANDS, self.DIM_PROPERTIES) and target_dimension is None:
642644
log.warning(
643645
f"Using experimental feature: DriverVectorCube.apply_dimension along dim {dimension} and empty cube"
644646
)
645-
# TODO: this is non-standard special case: vector cube with only geometries, but no "cube" data
647+
# TODO: data chunking (e.g. large feature collections)
646648
gdf = self._as_geopandas_df()
647649
feature_collection = openeo.udf.FeatureCollection(id="_", data=gdf)
650+
# TODO: dedicated UDF signature to indicate to work on vector cube through a feature collection based API
648651
udf_data = openeo.udf.UdfData(
649652
proj={"EPSG": self._geometries.crs.to_epsg()},
650653
feature_collection_list=[feature_collection],

0 commit comments

Comments
 (0)