add uri encoding for delete subscription call

Author: fadi-george

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/backend/impl/SubscriptionBackendService.kt

@@ -12,6 +12,7 @@ import com.onesignal.user.internal.backend.ISubscriptionBackendService
 import com.onesignal.user.internal.backend.SubscriptionObject
 import com.onesignal.user.internal.subscriptions.SubscriptionType
 import org.json.JSONObject
+import java.net.URLEncoder
 
 internal class SubscriptionBackendService(
     private val _httpClient: IHttpClient,
@@ -93,7 +94,8 @@ internal class SubscriptionBackendService(
         jwt: String?,
     ) {
         val type = subscriptionType.name.lowercase()
-        val response = _httpClient.delete("apps/$appId/by/type/$type/token/$subscriptionToken/subscriptions", OptionalHeaders(jwt = jwt))
+        val encodedToken = URLEncoder.encode(subscriptionToken, "UTF-8")
+        val response = _httpClient.delete("apps/$appId/by/type/$type/token/$encodedToken/subscriptions", OptionalHeaders(jwt = jwt))
 
         if (!response.isSuccess) {
             throw BackendException(response.statusCode, response.payload, response.retryAfterSeconds)

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/user/internal/backend/SubscriptionBackendServiceTests.kt

@@ -121,7 +121,7 @@ class SubscriptionBackendServiceTests : FunSpec({
         // Then
         coVerify {
             spyHttpClient.delete(
-                "apps/appId/by/type/email/token/test@example.com/subscriptions",
+                "apps/appId/by/type/email/token/test%40example.com/subscriptions",
                 any(),
             )
         }
@@ -144,7 +144,7 @@ class SubscriptionBackendServiceTests : FunSpec({
         exception.response shouldBe "NOT FOUND"
         coVerify {
             spyHttpClient.delete(
-                "apps/appId/by/type/sms/token/+1234567890/subscriptions",
+                "apps/appId/by/type/sms/token/%2B1234567890/subscriptions",
                 any(),
             )
         }