Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

No more than 200 Items are downloaded #144

Closed
Azar56 opened this issue Jan 5, 2019 · 1 comment
Closed

No more than 200 Items are downloaded #144

Azar56 opened this issue Jan 5, 2019 · 1 comment

Comments

@Azar56
Copy link

Azar56 commented Jan 5, 2019

As getNextPage() always returns null no more than 200 Items can be downloaded.
This is a serious limitation which makes this library unsuitable for my purposes.

In a downloaded version of this project I included the missing code in the module BaseItem.
However this module is flagged "This file is generated by a tool and any changes will be overwritten".
So my solution does not have a general character. However, my fix worked.

A second correction in the file ItemCollectionPage.java fixed the problem that getNextPage() stays forever != null even if there are no more second pages. Use for this the following code

public ItemCollectionPage(final BaseItemCollectionResponse response, IItemCollectionRequestBuilder builder) {
    super(response, builder);
    if (response.nextLink == null) super.setNextPage(null); // Inserted this new line
}

Please address this issue asap, as the usage of this library is seriously limited at the moment.

@baywet
Copy link
Member

baywet commented Oct 2, 2024

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #172 for more information

@baywet baywet closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants