Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you accept a PR to expand this mod? #2

Open
Darin755 opened this issue Dec 23, 2024 · 3 comments
Open

Would you accept a PR to expand this mod? #2

Darin755 opened this issue Dec 23, 2024 · 3 comments
Labels
question Further information is requested

Comments

@Darin755
Copy link

Currently I am thinking about building a mod/system that would allow digilines to mimic some of the functionality of TCP/IP.

Here's how it would work. I initial though about building the full TCP/IP stack but since digilines don't have a physical layer I am looking to do layer 3 and 4.

Here is what I am thinking:

  • digilines router that routes traffic based on channel name

  • a dhcp service that hands out unique channel names

  • a crypto library (hard so planned later)

  • some sort of transport that is like TCP

I am would prefer to add to this mod but I see that it hasn't been updated Ina few years. If you are done developing this I could always hard fork it and develop my own separate system.

Should I fork it or would you review and accept PRs?

@OgelGames
Copy link
Owner

OgelGames commented Dec 24, 2024

I'm always open to PRs on any of my mods, but for something that complex I think you'd be better off making a separate mod with digicontrol as a dependency. You might not even need a dependency on digicontrol for your idea, unless you need the "semiconductor" logic.

@OgelGames OgelGames added the question Further information is requested label Dec 24, 2024
@Darin755
Copy link
Author

Darin755 commented Jan 1, 2025

I think I will just create a separate mod, thanks

@Darin755 Darin755 closed this as completed Jan 1, 2025
@Darin755 Darin755 reopened this Jan 11, 2025
@Darin755
Copy link
Author

I did some thinking and I think I need to expand this mod a bit so that I can use it for more complex builds and potentially other mods. (That is why I reopened this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants