Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors from get_il_input_items are not reported in the API logs #1150

Open
carlfischerjba opened this issue Dec 4, 2024 · 1 comment · May be fixed by #1164
Open

Errors from get_il_input_items are not reported in the API logs #1150

carlfischerjba opened this issue Dec 4, 2024 · 1 comment · May be fixed by #1164

Comments

@carlfischerjba
Copy link
Collaborator

Issue Description

If there's a problem with the CondPriority or CondTag values, we should see an error, but the logs (in NRMC at least and presumably from the Oasis API) end with RUNNING: oasislmf.preparation.il_inputs.get_il_input_items and lack any specific error message. This makes it difficult to know what went wrong and what needs changing.

If we run oasislmf exposure run or an MDK analysis then we see the error (although it's not labelled clearly as an error).

Steps to Reproduce (Bugs only)

  1. Create a portfolio with mismatched CondTags (included below).
  2. Confirm that oasislmf exposure run flags an error on this file.
  3. Run an analysis via NRMC (or the Oasis API).

Version / Environment information

  • Worker oasislmf 2.3.10
  • Platform 2.3.9

Example data / logs

portfolio.zip

Output from oasislmf exposure run: error is shown (but there is no clear mention that this is an error).

...
RUNNING: oasislmf.preparation.il_inputs.get_il_input_items
Those condtag are present in locations but missing in the account file:
  PortNumber AccNumber CondTag
1          1         1    tag2

Running via the MDK also shows the message.

...
2024-12-03 18:33:04,691 [INFO] RUNNING: oasislmf.preparation.il_inputs.get_il_input_items
Those condtag are present in locations but missing in the account file:
  PortNumber AccNumber CondTag
1          1         1    tag2
2024-12-03 18:33:14,810 [ERROR] Those condtag are present in locations but missing in the account file:
  PortNumber AccNumber CondTag
1          1         1    tag2
ERROR: OasisLMF produced no results - see log output.

But running in NRMC, the analysis_*.log file ends without including the message.

...
2024-12-03 19:15:53,610 [INFO] RUNNING: oasislmf.preparation.summaries.get_summary_mapping
2024-12-03 19:15:53,619 [INFO] RUNNING: oasislmf.preparation.summaries.write_mapping_file
2024-12-03 19:15:53,624 [INFO] RUNNING: oasislmf.preparation.il_inputs.get_il_input_items
@carlfischerjba
Copy link
Collaborator Author

Maybe this belongs under OasisPlatform...

@sambles sambles transferred this issue from OasisLMF/OasisLMF Dec 4, 2024
@sambles sambles moved this to In Progress in Oasis Dev Team Tasks Dec 4, 2024
@sambles sambles self-assigned this Dec 4, 2024
@sambles sambles linked a pull request Feb 5, 2025 that will close this issue
@benhayes21 benhayes21 moved this from In Progress to Done in Oasis Dev Team Tasks Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants