Review and clean up any unused worker environment variables.

[sambles]

Issue Description

For example MODEL_DATA_DIRECTORY was historically used to point the worker to mode data (set in conf.ini)

OasisPlatform/conf.ini

Lines 1 to 2 in 20b0aa3

	[default]
	MODEL_DATA_DIRECTORY = /home/worker/model

In more recent versions its now only used to find the default oasislmf.json file

OasisPlatform/src/model_execution_worker/utils.py

Lines 110 to 114 in 20b0aa3

	def get_oasislmf_config_path(settings, model_id=None):
	""" Search for the oasislmf confiuration file
	"""
	conf_path = None
	model_root = settings.get('worker', 'model_data_directory', fallback='/home/worker/model')

We would be better of using the explicit OASIS_OASISLMF_CONFIG=<path-to-model-config.json> and removing MODEL_DATA_DIRECTORY

• Review all worker conf.ini options and remove any confusing / duplicated options.

[carlfischerjba]

Is this the same as the environment variable OASIS_MODEL_DATA_DIRECTORY used in the model registration script?

[sambles]

Oh good point.. it might be, i'd need to double check how its read into model_registration.sh but feels likely