-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rel attributes are reordered in 20220608.1 #336
Comments
draperunner
added a commit
to digipost/digipost-html-validator
that referenced
this issue
Apr 15, 2024
This upgrades the OWASP sanitizer library to the latest version. Guava is removed from this version. https://github.com/OWASP/java-html-sanitizer/releases/tag/release-20220608.1 The order of noreferrer, nofollow, noopener is apparently random now, so I had to rewrite those tests to not care about order (OWASP/java-html-sanitizer#336).
strangelookingnerd
added a commit
to strangelookingnerd/java-html-sanitizer
that referenced
this issue
Jan 3, 2025
daniel-beck
added a commit
to daniel-beck/update-center2
that referenced
this issue
Jan 26, 2025
daniel-beck
added a commit
to jenkins-infra/update-center2
that referenced
this issue
Jan 29, 2025
* Initial dependency updates * Update okhttp3, kotlin * Minimum for current parent pom * Java 11: Some fixes, update dependencies * Add workaround for OWASP/java-html-sanitizer#336 * Switch Jenkinsfile to Java 11 --------- Co-authored-by: Daniel Beck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upgrading to version 20240325.1 (previous 20220608.1 works fine) makes my testing failing because order of REL values changes. What is worse when I fix the order it passes with JDK17 but fails with JDK11
Test that starts failing
https://github.com/damianszczepanik/cucumber-reporting/blob/8aed0cc6e6c41413b87047d0b89f73d750d37206/src/test/java/net/masterthought/cucumber/generators/EscapeHtmlReferenceTest.java#L66
Error message for JDK11
PR with build/test output damianszczepanik/cucumber-reporting#1179
Basically having this implementation is hardly possible to maintain code that is tested against different JVMs
The text was updated successfully, but these errors were encountered: