Skip to content

Commit 1ed2254

Browse files
chromium: Backport missing dependency in NewTabPage (#816)
Cherry-pick of #815. Build and patch changes: ------------------------ Add one backported patch to fix a build race condition that would sometimes lead to build errors. License changes: ---------------- Added licenses: none. Removed licenses: none. Updated licenses: none. Test-built: ----------- * chromium-x11: - scarthgap, clang, MACHINE=qemux86-64 Signed-off-by: Max Ihlenfeldt <[email protected]> Co-authored-by: Daniel Semkowicz <[email protected]>
1 parent c3a84cc commit 1ed2254

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

meta-chromium/recipes-browser/chromium/chromium-gn.inc

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ B = "${S}/${OUTPUT_DIR}"
1313
# Backported patches.
1414
SRC_URI += "\
1515
file://backport/Add-missing-components-enterprise-buildflag.patch \
16+
file://backport/NewTabPage-Add-missing-dep-to-cr_components.patch \
1617
"
1718

1819
# Non-specific patches.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
From bd53e2fcd2ff2ab5f9726753b827e7f958ad1041 Mon Sep 17 00:00:00 2001
2+
From: dpapad <[email protected]>
3+
Date: Wed, 27 Mar 2024 23:05:52 +0000
4+
Subject: [PATCH] Backport "NewTabPage: Add missing dep to
5+
cr_components/history_clusters/."
6+
7+
This fixes transient build error caused by missing dependency.
8+
The patch will be included in upstream's 125 release.
9+
10+
Upstream-Status: Backport [https://crrev.com/c/5402989]
11+
Signed-off-by: Daniel Semkowicz <[email protected]>
12+
---
13+
chrome/browser/resources/new_tab_page/BUILD.gn | 1 +
14+
1 file changed, 1 insertion(+)
15+
16+
diff --git a/chrome/browser/resources/new_tab_page/BUILD.gn b/chrome/browser/resources/new_tab_page/BUILD.gn
17+
index 83736b4..64b5a0b 100644
18+
--- a/chrome/browser/resources/new_tab_page/BUILD.gn
19+
+++ b/chrome/browser/resources/new_tab_page/BUILD.gn
20+
@@ -104,6 +104,7 @@ build_webui("build") {
21+
"//ui/webui/resources/cr_components/color_change_listener:build_ts",
22+
"//ui/webui/resources/cr_components/customize_themes:build_ts",
23+
"//ui/webui/resources/cr_components/help_bubble:build_ts",
24+
+ "//ui/webui/resources/cr_components/history_clusters:build_ts",
25+
"//ui/webui/resources/cr_components/most_visited:build_ts",
26+
"//ui/webui/resources/cr_components/omnibox:build_ts",
27+
"//ui/webui/resources/cr_components/page_image_service:build_ts",

0 commit comments

Comments
 (0)