Fixes for #91

It was a copy and paste error when  I tried to fix #89

I copied the leg pattern from Hadamard gate which was actually not generally correct (okay for H matrix, which is symmetric).

Effectively, it was applying U gates in reverse.

Need to swap the leg order.

Tested by: running both the Python test scripts.

Signed-off-by: Thien Nguyen <[email protected]>

Author: Thien Nguyen

tnqvm/visitors/itensor/mps/ITensorMPSVisitor.cpp

@@ -501,11 +501,11 @@ void ITensorMPSVisitor::visit(U &u) {
   auto ind_in = ind_for_qbit(iqbit_in);
   auto ind_out = itensor::Index(u.name(), 2);
   auto tGate = itensor::ITensor(ind_in, ind_out);
-  tGate.set(ind_in(1), ind_out(1), std::cos(theta / 2.0));
-  tGate.set(ind_in(1), ind_out(2), -std::exp(std::complex<double>(0, lambda)) *
+  tGate.set(ind_out(1), ind_in(1), std::cos(theta / 2.0));
+  tGate.set(ind_out(1), ind_in(2), -std::exp(std::complex<double>(0, lambda)) *
                std::sin(theta / 2.0));
-  tGate.set(ind_in(2), ind_out(1), std::exp(std::complex<double>(0, phi)) * std::sin(theta / 2.0));
-  tGate.set(ind_in(2), ind_out(2), std::exp(std::complex<double>(0, phi + lambda)) *
+  tGate.set(ind_out(2), ind_in(1), std::exp(std::complex<double>(0, phi)) * std::sin(theta / 2.0));
+  tGate.set(ind_out(2), ind_in(2), std::exp(std::complex<double>(0, phi + lambda)) *
                std::cos(theta / 2.0));
   legMats[iqbit_in] = tGate * legMats[iqbit_in];
   printWavefunc();