Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] - Final form arrays poor performance #483

Closed
chrismclarke opened this issue May 9, 2019 · 1 comment · Fixed by #541
Closed

[bug] - Final form arrays poor performance #483

chrismclarke opened this issue May 9, 2019 · 1 comment · Fixed by #541

Comments

@chrismclarke
Copy link
Member

Describe the bug
You can see when adding/removing steps how janky the animation is. This is due to heavy re-renders and checking by final form

To Reproduce
Add remove how-to step or add a console log during the render method to count

Expected behavior
Minimal renders

Additional context
Common issue, discussion and potential solutions:
final-form/react-final-form-arrays#22
final-form/react-final-form#336
final-form/react-final-form#190
https://codesandbox.io/s/32r824vxy1

@chrismclarke
Copy link
Member Author

chrismclarke commented Aug 16, 2019

As a quick update, 3 months later and issues still open but some people say that latest versions should add some improvement. We are stuck on v3 so it would be worth somebody testing whether upgrade to v6 can be done without breaking too much!

See all release notes along with potential breaking changes here: https://github.com/final-form/react-final-form/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant