-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.7.4 - incongruent results between Conda and Biocontainers #73
Comments
I also went through the exercise of installing ConfindR manually, which matches the results from Conda. So I am leaning towards the container version returning incorrect results. The question is - why. Dependencies installed in each environment: Conda from BiocondaBBMap version 38.96 Biocontainers from BiocondaBBMap version 38.86 Which both seems to be in line with the requirements specified in the version-specific installation instructions (https://github.com/OLC-Bioinformatics/ConFindr/blob/fbfa7978aa800c19ea48c06ebb4ceda5e591935d/docs/install.md) |
And the test data used (after trimming with Fastp): ftp.sra.ebi.ac.uk/vol1/run/ERR117/ERR11797882/LC04-22-RV4-P64-C01_R1.fastq.gz |
I ended up building my own container here: https://hub.docker.com/repository/docker/mhoeppner/confindr/tags/0.7.4/sha256:a401ea0ea0b363fb64fcf55588aeb43b6b7fdb931bda2c5bd9ee403e47bf83a0 And that also matches the conda package. |
Right, so if the point here wasn't clear ;) The Biocontainer was build from the Conda package in 2020. If that installation of Confindr 0.7.4 yields different results from an installation directly from Bioconda today, the most likely interpretation (imho) is that the dependencies aren't defined tightly enough to ensure that reproducibility of results is possible. Which is a big problem. |
Hi,
so this is driving me a little nuts right now. I have a pipeline that provisions software either via Conda (discouraged) or a container (Singularity or Docker, mostly).
For legacy reasons, I am using ConfindR 0.7.4, with a custom database (https://zenodo.org/records/4604758), built for 0.7.4 here: https://gitlab.bfr.berlin/bfr_bioinformatics/aquamis_databases/-/raw/main/confindr_db.tar.gz
With a test sample, I am getting this with conda and singularity provided via Biocontainers (derived from Bioconda). Note that the conda-installed version of Confindr reports no SNVs, the Singularity-installed version (from Bioconda, https://quay.io/repository/biocontainers/confindr?tab=tags&tag=latest) reports 2 SNVs. It is my understanding that this should not be happening. And I cannot see major differences in the dependencies. Any ideas...?
And singularity
The text was updated successfully, but these errors were encountered: