From beb4be084d4db2878e81c4e28ba4f9ce8c77bab4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20THOMAS?= Date: Thu, 25 Jul 2024 12:31:14 +0200 Subject: [PATCH] Fix header.php Error 500 on logout Fix error 500 on logout based on the following trace: ===== [Thu Jul 25 10:12:29.680726 2024] [php:error] [pid 62:tid 62] [client 172.19.0.3:52588] PHP Fatal error: Uncaught TypeError: mysqli_fetch_row(): Argument #1 ($result) must be of type mysqli_result, bool given in /app/reports/require/header.php:205 Stack trace: #0 /app/reports/require/header.php(205): mysqli_fetch_row() #1 /app/reports/index.php(44): require('...') #2 {main} thrown in /app/reports/require/header.php on line 205, ===== --- require/header.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/require/header.php b/require/header.php index 3163b160d..4d1dc8f31 100644 --- a/require/header.php +++ b/require/header.php @@ -202,13 +202,15 @@ $sql = "SHOW COLUMNS FROM `%s`"; $arg = $item[0]; $res_column = mysql2_query_secure($sql, $_SESSION['OCS']["readServer"], $arg); - while ($item_column = mysqli_fetch_row($res_column)) { - - if ($item_column[0] == "HARDWARE_ID" && !isset($_SESSION['OCS']['SQL_TABLE_HARDWARE_ID'][$item[0]])) { - $_SESSION['OCS']['SQL_TABLE_HARDWARE_ID'][$item[0]] = $item[0]; + if ($res_column !== false) { + while ($item_column = mysqli_fetch_row($res_column)) { + + if ($item_column[0] == "HARDWARE_ID" && !isset($_SESSION['OCS']['SQL_TABLE_HARDWARE_ID'][$item[0]])) { + $_SESSION['OCS']['SQL_TABLE_HARDWARE_ID'][$item[0]] = $item[0]; + } + + $_SESSION['OCS']['SQL_TABLE'][$item[0]][$item_column[0]] = $item_column[0]; } - - $_SESSION['OCS']['SQL_TABLE'][$item[0]][$item_column[0]] = $item_column[0]; } } }