[17.0][MIG] base_external_dbsource_mysql: migration to version 17.0 #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Heavily refactor code for reusability * Split all sources into independent modules * Add more test coverage * Add CRUD methods * Add iterator execute return to roadmap [UPD] Update base_external_dbsource_mysql.pot
The amount of shared code is so insignificant, that it doesn't worth to depend on base_external_dbsource_sqlite. [UPD] Update base_external_dbsource_mysql.pot [ADD] icon.png
[UPD] Update base_external_dbsource_mysql.pot [UPD] README.rst
Contributor
Author
|
please review @Christian-RB |
christian-ramos-tecnativa
approved these changes
Aug 11, 2025
Contributor
christian-ramos-tecnativa
left a comment
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Tested locally. LGTM
|
It's ready to merge? |
1 task
Member
|
/ocabot migration base_external_dbsource_mysql |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at f650651. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to v17.
Bonus
@BinhexTeam
#247