[FIX] base_..._oauth: no need for basic type provider.

Basic authentication is no oauth at all and fully handled by base_external_system_http.

Author: NL66278

base_external_system_oauth/models/auth_oauth_provider.py

@@ -1,4 +1,4 @@
-# Copyright 2020 Therp BV <https://therp.nl>.
+# Copyright 2020-2024 Therp BV <https://therp.nl>.
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 # pylint: disable=no-self-use
 """Provide extra functionality to use Microsoft oauth for applications."""
@@ -22,9 +22,8 @@ class AuthOAuthProvider(models.Model):
     client_secret = fields.Char()
     provider_type = fields.Selection(
         selection=[
-            ("demo", "Use client_id and client_secret, but return fixed result"),
-            ("basic", "Use client_id and client_secret for basic Authentication"),
-            ("microsoft_client_secret", "Microsoft Client Secret autehntication"),
+            ("demo", "DEMO Just for testing purposes"),
+            ("microsoft_client_secret", "Microsoft Client Secret Authentication"),
         ],
         default="basic",
         help="Provider type determines the method to retrieve bearer token",
@@ -46,18 +45,6 @@ def _get_access_token_demo(self):
             return "you_are_in"
         raise UserError(_("Wrong client_id or client_secret"))
 
-    def _get_access_token_basic(self):
-        """Get access token using basic authentication."""
-        login_params = {
-            "grant_type": "client_credentials",
-        }
-        basic = HTTPBasicAuth(self.client_id, self.client_secret)
-        response = requests.post(
-            url=self.auth_endpoint, params=login_params, auth=basic, timeout=16
-        )
-        self._check_response(response)
-        return response.json()["access_token"]
-
     def _get_access_token_microsoft_client_secret(self):
         """Get access token from Microsoft."""
         login_url = "%(auth_endpoint)s/%(tenant_id)s%(validation_endpoint)s" % {