[IMP] repair_stock: use a non conflicting field for auxiliar transfers

`repair_id` is reserved to the stock.moves directly related
to the execution of the repair order and has associated logic
in odoo core code (like assigning the picking type)
To avoid unexpected behaviors, we use `related_repair_id` to
signal auxiliar stock moves that are not directly related to
repair execution.

To not break existing modules depending on it, support for
`repair_id` is kept but it is recommended to remove in v18.

Author: LoisRForgeFlow

repair_stock/models/__init__.py

@@ -1,3 +1,5 @@
 # Copyright 2024 ForgeFlow S.L. (https://www.forgeflow.com)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 from . import repair
+from . import stock_move
+from . import stock_rule

repair_stock/models/repair.py

@@ -27,6 +27,9 @@ def action_view_pickings(self):
 
     def _compute_picking_ids(self):
         for order in self:
+            # TODO: migration note: `repair_id` should not be used here
+            #  in v18, use `related_repair_id` instead while migrating
+            #  modules depending on this.
             moves = self.env["stock.move"].search(
                 [
                     ("related_repair_id", "=", order.id),

repair_stock/models/stock_move.py

@@ -0,0 +1,19 @@
+# Copyright 2024 ForgeFlow S.L. (https://www.forgeflow.com)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+from odoo import fields, models
+
+
+class StockMove(models.Model):
+    _inherit = "stock.move"
+
+    # `repair_id` is reserved to the stock.moves directly related
+    # to the execution of the repair order and has associated logic
+    # in odoo core code (like assigning the picking type)
+    # To avoid unexpected behaviors, we use `related_repair_id` to
+    # signal auxiliar stock moves that are not directly related to
+    # repair execution.
+    related_repair_id = fields.Many2one(
+        comodel_name="repair.order",
+        readonly=True,
+    )

repair_stock/models/stock_rule.py

@@ -0,0 +1,15 @@
+# Copyright 2023 ForgeFlow S.L. (https://www.forgeflow.com)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+from odoo import models
+
+
+class StockRule(models.Model):
+    _inherit = "stock.rule"
+
+    def _get_custom_move_fields(self):
+        move_fields = super()._get_custom_move_fields()
+        move_fields += [
+            "related_repair_id",
+        ]
+        return move_fields

repair_stock/tests/test_stock_repair_order.py

@@ -102,7 +102,7 @@ def _create_picking_and_move(self, repair_order):
                 "picking_type_id": self.warehouse.int_type_id.id,
                 "product_uom_qty": 1,
                 "product_uom": repair_order.product_id.uom_id.id,
-                "repair_id": repair_order.id,
+                "related_repair_id": repair_order.id,
             }
         )
         return picking
@@ -123,6 +123,7 @@ def test_action_view_pickings(self):
         repair_order._action_repair_confirm()
 
         picking = self._create_picking_and_move(repair_order)
+        self.assertEqual(picking.picking_type_id, self.warehouse.int_type_id)
         repair_order._compute_picking_ids()
 
         action = repair_order.action_view_pickings()