From c035a4ccad3b1c060df7a547ce337ea0a06ddc47 Mon Sep 17 00:00:00 2001
From: trisdoan <doanminhtri8183@gmail.com>
Date: Mon, 6 Jan 2025 11:33:26 +0700
Subject: [PATCH] [IMP] test_queue_job: add test for error_handler

---
 .../data/queue_job_function_data.xml          |  1 +
 test_queue_job/models/test_models.py          |  3 +++
 test_queue_job/tests/test_job.py              | 25 +++++++++++++++++++
 3 files changed, 29 insertions(+)

diff --git a/test_queue_job/data/queue_job_function_data.xml b/test_queue_job/data/queue_job_function_data.xml
index 8338045141..fe3cf686a6 100644
--- a/test_queue_job/data/queue_job_function_data.xml
+++ b/test_queue_job/data/queue_job_function_data.xml
@@ -3,6 +3,7 @@
         <field name="model_id" ref="test_queue_job.model_test_queue_job" />
         <field name="method">testing_method</field>
         <field name="related_action" eval='{"func_name": "testing_related_method"}' />
+        <field name="error_handler" eval='{"func_name": "testing_error_handler"}' />
     </record>
     <record
         id="job_function_test_queue_job_job_with_retry_pattern"
diff --git a/test_queue_job/models/test_models.py b/test_queue_job/models/test_models.py
index f810dba862..fde403f529 100644
--- a/test_queue_job/models/test_models.py
+++ b/test_queue_job/models/test_models.py
@@ -29,6 +29,9 @@ def testing_related__url(self, **kwargs):
             "url": kwargs["url"].format(subject=subject),
         }
 
+    def testing_error_handler(self, **kwargs):
+        return None
+
 
 class ModelTestQueueJob(models.Model):
 
diff --git a/test_queue_job/tests/test_job.py b/test_queue_job/tests/test_job.py
index 1585f992f0..c451fa4a0d 100644
--- a/test_queue_job/tests/test_job.py
+++ b/test_queue_job/tests/test_job.py
@@ -2,12 +2,15 @@
 # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html)
 
 import hashlib
+import logging
 from datetime import datetime, timedelta
 from unittest import mock
+from unittest.mock import patch
 
 import odoo.tests.common as common
 
 from odoo.addons.queue_job import identity_exact
+from odoo.addons.queue_job.controllers.main import RunJobController
 from odoo.addons.queue_job.delay import DelayableGraph
 from odoo.addons.queue_job.exception import (
     FailedJobError,
@@ -24,9 +27,12 @@
     WAIT_DEPENDENCIES,
     Job,
 )
+from odoo.addons.queue_job.tests.common import trap_jobs
 
 from .common import JobCommonCase
 
+_logger = logging.getLogger(__name__)
+
 
 class TestJobsOnTestingMethod(JobCommonCase):
     """Test Job"""
@@ -341,6 +347,25 @@ def test_job_identity_key_func_exact(self):
         job1 = Job.load(self.env, test_job_1.uuid)
         self.assertEqual(job1.identity_key, expected_key)
 
+    def test_failed_job_perform(self):
+        with trap_jobs() as trap:
+            model = self.env["test.queue.job"]
+            job = model.with_delay(priority=1, max_retries=1).testing_method()
+            trap.assert_jobs_count(1)
+            with patch.object(type(job), "perform", side_effect=IOError), patch(
+                "odoo.sql_db.Cursor.commit", return_value=None
+            ):  # avoid odoo.sql_db: bad query: ROLLBACK TO SAVEPOINT test_0
+                controller = RunJobController()
+                try:
+                    controller._try_perform_job(self.env, job)
+                    with patch(
+                        "odoo.addons.test_queue_job.models.test_models.QueueJob"
+                        ".testing_error_handler"
+                    ) as patched:
+                        patched.assert_called_once()
+                except Exception:
+                    _logger.info("Job fails")
+
 
 class TestJobs(JobCommonCase):
     """Test jobs on other methods or with different job configuration"""