[BUG] hr_expense_advance_clearing advance paid by company

[unique4]

Employee advance is paid directly company account, what is the purpose of this constraint?

hr-expense/hr_expense_advance_clearing/models/hr_expense.py

Lines 50 to 51 in 170f04e

	if expense.payment_mode != "own_account":
	raise ValidationError(_("Employee advance, paid by must be employee"))

[Saran440]

Hi.
For me, Advance means the company gives money to the employee.
So, I think it's make sense. and process company and employee are difference.

[unique4]

Hi @Saran440,
Both expense payment mode are company gives money, but the differences is accounting entry (tested at Odoo 16 version)

• paid by employee: a bill is created (accounting entry between payable and targeted advance account)
• paid by company: a journal entry is created, between bank/cash account and targeted advance account

So I think payment paid by company makes more sense for the advance, since there is no bill (nothing bought) at the time advance is created, the payable account should not be used here. The bill is created in the clearing advance.