[FIX] account_check_report: bug

Author: AaronHForgeFlow

account_check_report/models/account_payment.py

@@ -13,7 +13,7 @@ class AccountPayment(models.Model):
     def _compute_stat_buttons_from_reconciliation(self):
         res = super()._compute_stat_buttons_from_reconciliation()
         for rec in self:
-            if self.payment_type == "outbound":
+            if rec.payment_type == "outbound":
                 open_action = rec.button_open_bills()
                 result_domain = open_action.get("domain", False)
                 if not result_domain:
@@ -62,8 +62,10 @@ def get_direct_refunds(self):
         return invoice_ids
 
     def get_direct_refunds_domain(self):
-        invoice_ids = self.get_direct_refunds()
-        return [("id", "in", invoice_ids.ids)]
+        invoices = self.get_direct_refunds()
+        if invoices:
+            return [("id", "in", invoices.ids)]
+        return []
 
     def button_open_invoices(self):
         res = super(AccountPayment, self).button_open_invoices()

account_check_report/tests/test_account_check_report.py

@@ -9,11 +9,11 @@
 class TestAccountCheckReport(TransactionCase):
     def setUp(self):
         super(TestAccountCheckReport, self).setUp()
-        self.account_invoice_model = self.env["account.invoice"]
         self.journal_model = self.env["account.journal"]
-        self.register_payments_model = self.env["account.register.payments"]
+        self.account_move_model = self.env["account.move"]
+        self.account_move_line_model = self.env["account.move.line"]
+        self.register_payments_model = self.env["account.payment.register"]
         self.payment_method_model = self.env["account.payment.method"]
-        self.account_invoice_line_model = self.env["account.invoice.line"]
         self.account_account_model = self.env["account.account"]
         self.payment_model = self.env["account.payment"]
 
@@ -50,7 +50,7 @@ def setUp(self):
                 "type": "bank",
                 "code": "bank",
                 "check_manual_sequencing": True,
-                "outbound_payment_method_ids": [
+                "outbound_payment_method_line_ids": [
                     (4, self.payment_method_check.id, None)
                 ],
             }
@@ -69,11 +69,11 @@ def _create_account(self, name, code, user_type, reconcile):
         return account
 
     def _create_vendor_bill(self, account):
-        vendor_bill = self.account_invoice_model.create(
+        vendor_bill = self.account_move_model.with_context(
+            default_move_type="in_invoice"
+        ).create(
             {
-                "type": "in_invoice",
                 "partner_id": self.partner1.id,
-                "account_id": account.id,
                 "currency_id": self.company.currency_id.id,
                 "journal_id": self.purchase_journal.id,
                 "company_id": self.company.id,
@@ -82,13 +82,13 @@ def _create_vendor_bill(self, account):
         return vendor_bill
 
     def _create_invoice_line(self, account, invoice):
-        invoice_line = self.account_invoice_line_model.create(
+        invoice_line = self.account_move_line_model.create(
             {
                 "name": "Test invoice line",
                 "account_id": account.id,
                 "quantity": 1.000,
                 "price_unit": 2.99,
-                "invoice_id": invoice.id,
+                "move_id": invoice.id,
                 "product_id": self.product.id,
             }
         )
@@ -106,7 +106,7 @@ def test_01_check_printing(self):
         self._create_invoice_line(acc_expense, vendor_bill)
         vendor_bill.action_invoice_open()
         ctx = {
-            "active_model": "account.invoice",
+            "active_model": "account.move",
             "active_ids": [vendor_bill.id],
         }
         register_payments = self.register_payments_model.with_context(**ctx).create(
@@ -134,7 +134,7 @@ def test_02_get_invoices(self):
         self._create_invoice_line(acc_expense, vendor_bill)
         vendor_bill.action_invoice_open()
         ctx = {
-            "active_model": "account.invoice",
+            "active_model": "account.move",
             "active_ids": [vendor_bill.id],
         }
         register_payments = self.register_payments_model.with_context(**ctx).create(