Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition Github Repo follow up #6166

Closed
2 of 3 tasks
kanej opened this issue Jan 21, 2025 · 2 comments · Fixed by #6184
Closed
2 of 3 tasks

Ignition Github Repo follow up #6166

kanej opened this issue Jan 21, 2025 · 2 comments · Fixed by #6184
Assignees
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone

Comments

@kanej
Copy link
Member

kanej commented Jan 21, 2025

The move of Hardhat Ignition into the Hardhat repo is complete at a commit level and at a CI level.

We have a small set of clean-up tasks that were separated out:

TODO

  • Refactor hardhat-toolbox and the viem toolbox to use the workspace versions of Ignition
  • Ensure Hardhat Ignition packages are deployable from within the Hardhat repo
  • Enable hardhat-ignition-examples
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 21, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jan 21, 2025
@kanej kanej added v-next A Hardhat v3 development task status:ready This issue is ready to be worked on and removed status:ready This issue is ready to be worked on labels Jan 21, 2025
@kanej kanej moved this from Backlog to To-do in Hardhat Jan 21, 2025
@kanej kanej added this to the Public Alpha milestone Jan 21, 2025
@kanej kanej self-assigned this Jan 23, 2025
@kanej kanej moved this from To-do to In Progress in Hardhat Jan 23, 2025
@kanej
Copy link
Member Author

kanej commented Jan 24, 2025

I am holding on re-enabling the Ignition examples. We should bring it in when we move to v-next. I ran into fun and games with pnpm. Rather than solve it twice, lets solve it once in the v-next branch.

@kanej
Copy link
Member Author

kanej commented Jan 24, 2025

I have done a run through of a local verdaccio deploy based on a change to the @nomicfoundation/hardhat-ignition being published via changeset.
That local install worked cleanly.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Hardhat Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant