Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private keys as string in v3 #5979

Closed
kanej opened this issue Nov 25, 2024 · 2 comments
Closed

Private keys as string in v3 #5979

kanej opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone

Comments

@kanej
Copy link
Member

kanej commented Nov 25, 2024

When a user provides a private key as a string in HHv2, the 0x is optional.
In v3 we should trim the 0x everywhere.

@kanej kanej added the v-next A Hardhat v3 development task label Nov 25, 2024
@kanej kanej added this to Hardhat Nov 25, 2024
@kanej kanej moved this to To-do in Hardhat Nov 25, 2024
@kanej kanej added this to the Private Alpha Follow-up milestone Nov 25, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 25, 2024
@schaable schaable assigned schaable and unassigned schaable Jan 2, 2025
@kanej kanej moved this from To-do to In Review in Hardhat Jan 10, 2025
@schaable
Copy link
Member

@alcuadrado Does this mean the user can input private keys (only the private keys) in the accounts section of the network config, either with or without the "0x" prefix, and we internally resolve it to the prefixed version?

@schaable
Copy link
Member

Updating the issue for future reference: Users can input the private keys in networkConfig.accounts either with or without the "0x" prefix. Internally, they are normalized to a "0x" prefixed string.

@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: Done
Development

No branches or pull requests

2 participants