Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micro-eth-signer issue when deploying local accounts #5967

Closed
2 of 3 tasks
kanej opened this issue Nov 21, 2024 · 0 comments · Fixed by #6017
Closed
2 of 3 tasks

micro-eth-signer issue when deploying local accounts #5967

kanej opened this issue Nov 21, 2024 · 0 comments · Fixed by #6017
Assignees
@ChristopherDedominici
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone
Public Alpha

Comments

@kanej
Copy link
Member

kanej commented Nov 21, 2024 •
edited by ChristopherDedominici
Loading

There was an issue with micro-eth-signer that has been fixed here: https://github.com/paulmillr/micro-eth-signer/releases/tag/0.12.2

Specifically it didn't allow a zero address when deploying a contract. Even with the fix micro-eth-signer, it doesn't support sending a transaction to the null address without data. As this is likely a user error we should throw in that situation.

TODO

  • Update to the fixed version of micro-eth-signer
  • Add tests to cover previous bug
  • Add a guard and tests to cover the case where the transaction address is null without data
@kanej kanej added the v-next A Hardhat v3 development task label Nov 21, 2024
@kanej kanej added this to the Private Alpha Follow-up milestone Nov 21, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Nov 21, 2024
@kanej kanej moved this from Backlog to To-do in Hardhat Nov 21, 2024
@kanej kanej mentioned this issue Nov 27, 2024
Closed
@ChristopherDedominici ChristopherDedominici moved this from To-do to In Progress in Hardhat Dec 2, 2024
@ChristopherDedominici ChristopherDedominici linked a pull request Dec 5, 2024 that will close this issue
micro-eth-signer issue when deploying local accounts #6017
Merged
@ChristopherDedominici ChristopherDedominici moved this from In Progress to In Review in Hardhat Dec 5, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Dec 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChristopherDedominici ChristopherDedominici

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
Public Alpha
Development

Successfully merging a pull request may close this issue.

micro-eth-signer issue when deploying local accounts NomicFoundation/hardhat
2 participants
@kanej @ChristopherDedominici