Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Mismatch in Network Fields Using configVariable #5907

Closed
schaable opened this issue Oct 30, 2024 · 0 comments
Closed

Type Mismatch in Network Fields Using configVariable #5907

schaable opened this issue Oct 30, 2024 · 0 comments
Assignees
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone

Comments

@schaable
Copy link
Member

When using configVariable("variable_name") from hardhat-keystore in network configurations like url and accounts, TypeScript throws an error: Type 'ConfigurationVariable' is not assignable to type ...

For example:

networks: {
  myNetwork: {
    ...
    url: configVariable('OP_SEPOLIA_URL') // Type 'ConfigurationVariable' is not assignable to type 'string'.
  }
}

We should update sensitive fields types to accept the ConfigurationVariable type.

@schaable schaable added this to the Private Alpha milestone Oct 30, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 30, 2024
@schaable schaable added the v-next A Hardhat v3 development task label Oct 30, 2024
@schaable schaable self-assigned this Oct 30, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Oct 30, 2024
@kanej kanej moved this from Backlog to To-do in Hardhat Oct 31, 2024
@kanej kanej moved this from In Progress to To-do in Hardhat Nov 27, 2024
@kanej kanej moved this from To-do to In Review in Hardhat Jan 10, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: Done
Development

No branches or pull requests

2 participants