Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Semantic Highlighting and Outline to use Slang@19 #632

Open
kanej opened this issue Jan 30, 2025 · 0 comments
Open

Update Semantic Highlighting and Outline to use Slang@19 #632

kanej opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
status:ready This issue is ready to be worked on

Comments

@kanej
Copy link
Member

kanej commented Jan 30, 2025

Slang@19 comes with bug fixes and runs in WASM, but implies some changes to the API.

Because Slang@19 is ESM, we need to do dynamic imports to use it from the extension's commonjs code:

const { Language } = await import("@nomicfoundation/slang")

This will require reworking the structure of the supporting classes in Semantic Highlighting and Outline.

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 30, 2025
@kanej kanej added this to Hardhat Jan 30, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jan 30, 2025
@kanej kanej moved this from Backlog to To-do in Hardhat Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: To-do
Development

No branches or pull requests

2 participants