Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placing Snow causes crash #44

Closed
officereso opened this issue Jan 24, 2025 · 1 comment
Closed

Placing Snow causes crash #44

officereso opened this issue Jan 24, 2025 · 1 comment

Comments

@officereso
Copy link

Build: nomi-ceu-main-81f6824-client
Also effects: 1.7.3

latest.log

Placing snow layers on non snow layer blocks causes a crash.

This crash seems very similar to the BoP crash I mentioned in Nomi-CEu/Nomi-CEu#1156 (comment)
Both are coming from this line:

if (event.getFace() != null && !itemBlock.getBlock().isReplaceable(event.getWorld(), pos))

I originally said the BoP related crash was a BoP bug but if a similar issue affects vanilla blocks it's possible the handleAndCancelPlace implementation is incorrect. If this is the case 2ee6334 might not have been necessary.
Unless this is simply a bug in the vanilla implementation for net.minecraft.block.BlockSnow.isReplaceable. I'm not familiar enough with minecrafts API to know if this is a vanilla bug, or a misuse of NomiLabs's isReplaceable call.

@IntegerLimit
Copy link
Member

Fixed: See b27e4a0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants