refactor(scanner) remove useless try finally in verify (#464)

Author: clemgbld

.changeset/fast-eagles-go.md

@@ -0,0 +1,4 @@
+---
+"@nodesecure/scanner": minor
+---
+refactor(scanner): remove useless try finally surrounding extractAndResolve in verify

workspaces/scanner/src/depWalker.ts

@@ -1,7 +1,6 @@
 // Import Node.js Dependencies
 import path from "node:path";
 import { readFileSync } from "node:fs";
-import timers from "node:timers/promises";
 
 // Import Third-party Dependencies
 import { Mutex, MutexRelease } from "@openally/mutex";
@@ -192,7 +191,6 @@ export async function depWalker(
 
     logger.end(ScannerLoggerEvents.analysis.tree);
     await Promise.allSettled(operationsQueue);
-    await timers.setImmediate();
 
     logger
       .end(ScannerLoggerEvents.analysis.tarball)
@@ -283,8 +281,6 @@ export async function depWalker(
     return payload as Payload;
   }
   finally {
-    await timers.setImmediate();
-
     logger.emit(ScannerLoggerEvents.done);
   }
 }

workspaces/scanner/src/index.ts

@@ -1,7 +1,6 @@
 // Import Node.js Dependencies
 import path from "node:path";
 import fs from "node:fs/promises";
-import timers from "node:timers/promises";
 import os from "node:os";
 
 // Import Third-party Dependencies
@@ -90,18 +89,14 @@ export async function verify(
 
   await using tempDir = await TempDirectory.create();
 
-  try {
-    const mama = await tarball.extractAndResolve(tempDir.location, {
-      spec: packageName,
-      registry: getLocalRegistryURL()
-    });
-    const scanResult = await tarball.scanPackage(mama);
+  const mama = await tarball.extractAndResolve(tempDir.location, {
+    spec: packageName,
+    registry: getLocalRegistryURL()
+  });
 
-    return scanResult;
-  }
-  finally {
-    await timers.setImmediate();
-  }
+  const scanResult = await tarball.scanPackage(mama);
+
+  return scanResult;
 }
 
 export {