Merge pull request #461 from clemgbld/refacto/async-dispose-temp-directory-class

refactor(TempDirectory): use Symbol.asyncDispose for async cleanup

Author: clemgbld

.changeset/bright-insects-cough.md

@@ -0,0 +1,5 @@
+---
+"@nodesecure/scanner": minor
+---
+
+refactor(TempDirectory): use Symbol.asyncDispose for automatic async cleanup

workspaces/scanner/src/class/TempDirectory.class.ts

@@ -34,4 +34,8 @@ export class TempDirectory {
 
     return this;
   }
+
+  async [Symbol.asyncDispose]() {
+    await this.clear();
+  }
 }

workspaces/scanner/src/depWalker.ts

@@ -94,7 +94,7 @@ export async function depWalker(
     registry
   } = options;
 
-  const tempDir = await TempDirectory.create();
+  await using tempDir = await TempDirectory.create();
 
   const payload: Partial<Payload> = {
     id: tempDir.id,
@@ -284,7 +284,6 @@ export async function depWalker(
   }
   finally {
     await timers.setImmediate();
-    await tempDir.clear();
 
     logger.emit(ScannerLoggerEvents.done);
   }

workspaces/scanner/src/index.ts

@@ -88,7 +88,7 @@ export async function verify(
     return tarball.scanPackage(process.cwd());
   }
 
-  const tempDir = await TempDirectory.create();
+  await using tempDir = await TempDirectory.create();
 
   try {
     const mama = await tarball.extractAndResolve(tempDir.location, {
@@ -101,7 +101,6 @@ export async function verify(
   }
   finally {
     await timers.setImmediate();
-    await tempDir.clear();
   }
 }