fix(EntryFilesAnalyser): join non-absolute entry files when rootPath is provided (#345)

Author: fraxken

src/EntryFilesAnalyser.js

@@ -41,11 +41,12 @@ export class EntryFilesAnalyser {
     this.dependencies = new DiGraph();
 
     for (const entryFile of new Set(entryFiles)) {
-      const normalizedEntryFile = path.normalize(
-        fileURLToPathExtended(entryFile)
-      );
+      const normalizedEntryFile = this.#normalizeAndCleanEntryFile(entryFile);
 
-      if (this.ignoreENOENT && !await this.#fileExists(normalizedEntryFile)) {
+      if (
+        this.ignoreENOENT &&
+        !await this.#fileExists(normalizedEntryFile)
+      ) {
         return;
       }
 
@@ -57,8 +58,21 @@ export class EntryFilesAnalyser {
     }
   }
 
+  #normalizeAndCleanEntryFile(file) {
+    let normalizedEntryFile = path.normalize(
+      fileURLToPathExtended(file)
+    );
+    if (this.#rootPath !== null && !path.isAbsolute(normalizedEntryFile)) {
+      normalizedEntryFile = path.join(this.#rootPath, normalizedEntryFile);
+    }
+
+    return normalizedEntryFile;
+  }
+
   #getRelativeFilePath(file) {
-    return this.#rootPath ? path.relative(this.#rootPath, file) : file;
+    return this.#rootPath ?
+      path.relative(this.#rootPath, file) :
+      file;
   }
 
   async* #analyseFile(

test/EntryFilesAnalyser.spec.js

@@ -181,23 +181,43 @@ describe("EntryFilesAnalyser", () => {
       assert.ok(to.startsWith(kFixtureURLPath));
     }
   });
-});
 
-it("should ignore file that does not exist when option ignoreENOENT is provided", async() => {
-  const entryFilesAnalyser = new EntryFilesAnalyser({
-    ignoreENOENT: true,
-    rootPath: kFixtureURL
+  it("should automatically build absolute path for entryFiles when rootPath is provided", async() => {
+    const entryFilesAnalyser = new EntryFilesAnalyser({
+      rootPath: kFixtureURL
+    });
+
+    const generator = entryFilesAnalyser.analyse(
+      ["recursive/A.js"]
+    );
+    const reports = await fromAsync(generator);
+
+    const files = reports.map((report) => path.normalize(report.file));
+    assert.deepEqual(
+      files,
+      [
+        "recursive/A.js",
+        "recursive/B.js"
+      ].map((file) => path.normalize(file))
+    );
   });
 
-  const entryUrl = new URL("does-not-exists.js", kFixtureURL);
+  it("should ignore file that does not exist when option ignoreENOENT is provided", async() => {
+    const entryFilesAnalyser = new EntryFilesAnalyser({
+      ignoreENOENT: true,
+      rootPath: kFixtureURL
+    });
+
+    const entryUrl = new URL("does-not-exists.js", kFixtureURL);
 
-  const generator = entryFilesAnalyser.analyse(
-    [entryUrl]
-  );
+    const generator = entryFilesAnalyser.analyse(
+      [entryUrl]
+    );
 
-  const reports = await fromAsync(generator);
-  assert.strictEqual(reports.length, 0);
-  assert.strictEqual(entryFilesAnalyser.dependencies.hasVertex("does-not-exists.js"), false);
+    const reports = await fromAsync(generator);
+    assert.strictEqual(reports.length, 0);
+    assert.strictEqual(entryFilesAnalyser.dependencies.hasVertex("does-not-exists.js"), false);
+  });
 });
 
 // TODO: replace with Array.fromAsync when droping Node.js 20