Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: openmw #370061

Closed
Sirius902 opened this issue Jan 1, 2025 · 3 comments · Fixed by #370126
Closed

Build failure: openmw #370061

Sirius902 opened this issue Jan 1, 2025 · 3 comments · Fixed by #370126
Assignees
Labels

Comments

@Sirius902
Copy link
Contributor

Steps To Reproduce

Steps to reproduce the behavior:

  1. Build openmw for nixpkgs master (currently e3971d5) using the following.

nix build 'github:nixos/nixpkgs?rev=e3971d53ab8229477aca688b45a94d8c4babf5d8#openmw'

Build log

Had to upload to hastebin due to Comment is too long (maximum is 65536 characters).

https://hastebin.com/share/uxumuridaw.bash

Additional context

Currently in the process of git bisect-ing to find out when this issue was introduced. I think this was probably due to a compiler upgrade at some point and the algorithm header was included by chance but now it isn't. I noticed the algorithm header is included explicitly in openmw master but not in the release the nix package is currently based on so I suspect using a newer version of the openmw source would probably work.

https://github.com/OpenMW/openmw/blob/6ac0880cf367de07a1c7a8218a94f31c13902f12/components/bsa/bsa_file.cpp#L29

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.11.11, NixOS, 25.05 (Warbler), 25.05.20241219.d70bd19`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.11`
 - nixpkgs: `/nix/store/8fwsiv0hd7nw1brkvka0jf1frk3m7qkr-source`

Notify maintainers

@abbradar @marius851000


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@Sirius902 Sirius902 added the 0.kind: build failure A package fails to build label Jan 1, 2025
@SigmaSquadron SigmaSquadron self-assigned this Jan 2, 2025
@SigmaSquadron
Copy link
Contributor

The <algorithm> backport does indeed fix bsa_file.cpp. I'm running a build to see if it there are more out of scope function calls.

@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Jan 2, 2025

Another one in charactermanager.hpp: std::list. Rebuilding.

@SigmaSquadron
Copy link
Contributor

Build succeeded! #370126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants