File tree 1 file changed +3
-1
lines changed
1 file changed +3
-1
lines changed Original file line number Diff line number Diff line change @@ -80,6 +80,7 @@ Reviewing process:
80
80
81
81
- Ensure that all file paths [ fit the guidelines] ( ../CONTRIBUTING.md#file-naming-and-organisation ) .
82
82
- Ensure that the module tests, if any, are succeeding.
83
+ - Ensure that new module tests are added to the package ` passthru.tests ` .
83
84
- Ensure that the introduced options are correct.
84
85
- Type should be appropriate (string related types differs in their merging capabilities, ` loaOf ` and ` string ` types are deprecated).
85
86
- Description, default and example should be provided.
@@ -95,7 +96,8 @@ Sample template for a new module review is provided below.
95
96
##### Reviewed points
96
97
97
98
- [ ] module path fits the guidelines
98
- - [ ] module tests succeed on ARCHITECTURE
99
+ - [ ] module tests, if any, succeed on ARCHITECTURE
100
+ - [ ] module tests, if any, are added to package `passthru.tests`
99
101
- [ ] options have appropriate types
100
102
- [ ] options have default
101
103
- [ ] options have example
You can’t perform that action at this time.
0 commit comments